Feature: external editor support #123 by GachiLord · Pull Request #177 · Julien-cpsn/ATAC

GachiLord · 2025-09-28T16:09:05Z

What's new

This PR adds ability to modify the following request properties via system's editor:

Body
URL
Pre-request and post-request scripts

The editor is invoked via alternative keybinding, so the original way of editing still works and users can choose what they prefer. The keybindings are included in this PR, but I haven't thought on the usability much so feel free to change them.

Mac and default keybindings:

Edit body and scripts via "Shift-R"
Edit URL via "Shift-U"

Vim keybindings:

Edit body and scripts via "Shift-E"
Edit URL via "Ctrl-U"

What's changed

Add editor invoking functions. This guide was used for the implementation
Add edit crate that allows calling system's editor in a cross-platform way
Add terminal argument to src/tui/events.rs:handle_events, so we can interrupt the render loop when handling editor events
Disable default features in syntect crate to use its pure-rust mode without onig dependency, which doesn't build on many machines including mine

Testing

It works on alacritty 0.15.1(openSUSE 6.16.7-1-default) and Gnome Terminal 48.1(Fedora 42) but I haven't tested it on other platforms.

Sorry for many LOC and long PR message, have a nice day!

Julien-cpsn · 2025-09-28T19:46:44Z

Hello,

Very good pr thanks!!!

I reviewed most of it on my phone (which is a pretty good sign). My only criticism before testing it would be that every event needs its function, so you should move the business logic in an appropriate file. I can do it myself, no problem about that.

That'll fix the "Editing body is hard" problem I guess (I took it personally 😢)

Have a great day too!!

Julien-cpsn · 2025-09-28T19:51:41Z

#123

GachiLord · 2025-09-28T20:11:07Z

It would be nice if you created a function for handling those events by yourself. Thanks.

Also there is a common wisdom that everyone tries to create their own vim just to see it's not as neet as a real one :)

Rimann91 · 2025-11-18T21:58:41Z

Is this PR going to get merged? Looks like its been outstanding for a couple of months now.

Julien-cpsn · 2025-11-19T01:24:13Z

Hi!
Yes sure I'll give it a look... when I have the time to

As said in others PR/issues/discord, I will only merge quality code and deeply reviewed PRs, and it takes much time. I really want to give full attention to this work.

You're the next on the TODO list tbh

Have a great day

Julien-cpsn · 2025-12-26T12:01:05Z

src/tui/utils/system_editor.rs

+use crate::tui::utils::stateful::text_input::TextInput;
+
+
+pub fn run(terminal: &mut Terminal<impl Backend>, default_text: &str, file_extension: &str) -> Result<String> {


Should not be pub

Julien-cpsn · 2025-12-26T21:24:45Z

Cargo.toml

 tracing-log = "=0.2.0"
 ## Opentracing middleware implementation for reqwest-middleware
-reqwest-tracing = "=0.5.8"
+reqwest-tracing = "=0.5.8"


No line return needed

Julien-cpsn · 2025-12-26T21:24:54Z

example_resources/key_bindings/default_key_bindings.toml

 yank_response_part = "y" # Used to yank the current result tab (e.g. body, headers, cookies)

-result_next_tab = "Shift-BackTab" # Will use param_next_tab depending on the selected view
+result_next_tab = "Shift-BackTab" # Will use param_next_tab depending on the selected view


No line return needed

Julien-cpsn · 2025-12-26T21:25:00Z

example_resources/key_bindings/mac_key_bindings.toml

 yank_response_part = "y" # Used to yank the current result tab (e.g. body, headers, cookies)

-result_next_tab = "Shift-BackTab" # Will use param_next_tab depending on the selected view
+result_next_tab = "Shift-BackTab" # Will use param_next_tab depending on the selected view


No line return needed

Julien-cpsn · 2025-12-26T21:25:08Z

example_resources/key_bindings/vim_key_bindings.toml

 yank_response_part = "Shift-Y" # Used to yank the current result tab (e.g. body, headers, cookies)

-result_next_tab = "Ctrl-t" # Will use param_next_tab depending on the selected view
+result_next_tab = "Ctrl-t" # Will use param_next_tab depending on the selected view


No line return needed

Julien-cpsn · 2025-12-26T21:27:53Z

src/tui/events.rs

                    KeyCombination { codes: One(KeyCode::Char(char)), .. } => self.body_text_area.insert_char(char),
                    _ => {}
                },
+                EditRequestBodySystemEditor(_) => {


Should be in a separate function

Julien-cpsn · 2025-12-26T21:28:49Z

src/tui/tui_logic/request/http/body.rs

+        let request = local_selected_request.read();
+        let request = request.get_http_request().unwrap();
+
+        match request.body {


Should create a method for ContentType called to_file_extension

Julien-cpsn · 2025-12-26T21:30:42Z

src/tui/tui_logic/request/http/body.rs

+    pub fn tui_request_body_file_extension(&self) -> Option<&'static str> {
+        let selected_request_index = &self.collections_tree.selected.unwrap();
+        let local_selected_request = self.get_request_as_local_from_indexes(selected_request_index);
+        let request = local_selected_request.read();


Should be placed in a sub-scope

Julien-cpsn · 2025-12-26T21:30:54Z

src/tui/tui_logic/request/http/body.rs

+        let selected_request_index = &self.collections_tree.selected.unwrap();
+        let local_selected_request = self.get_request_as_local_from_indexes(selected_request_index);
+        let request = local_selected_request.read();
+        let request = request.get_http_request().unwrap();


Should be renamed http_request

Julien-cpsn · 2025-12-26T21:31:23Z

src/tui/utils/stateful/text_input.rs

        self.reset_cursor();
    }

+    pub fn set_input(&mut self, text: String) {


Should be renamed set_input_content

Julien-cpsn · 2025-12-26T21:34:49Z

src/tui/app_states.rs

                    Documentation(EventKeyBinding::new(vec![key_bindings.generic.display_help], "Display help", Some("Help"))),

                    EditUrl(EventKeyBinding::new(vec![key_bindings.request_selected.change_url], "Edit URL", Some("URL"))),
+                    EditUrlSystemEditor(EventKeyBinding::new(vec![key_bindings.request_selected.alt_change_url], "Edit URL via system editor", Some("URL"))),


"Same via system editor"

Julien-cpsn · 2025-12-26T21:34:55Z

src/tui/app_states.rs

                        ],
                        RequestParamsTabs::Body => vec![
                            EditRequestBody(EventKeyBinding::new(vec![key_bindings.generic.list_and_table_actions.edit_element], "Edit body", None)),
+                            EditRequestBodySystemEditor(EventKeyBinding::new(vec![key_bindings.generic.list_and_table_actions.alt_edit_element], "Edit body via system editor", None)),


"Same via system editor"

Julien-cpsn · 2025-12-26T21:35:01Z

src/tui/app_states.rs

                        ],
                        RequestParamsTabs::Scripts => vec![
                            EditRequestScript(EventKeyBinding::new(vec![key_bindings.generic.list_and_table_actions.edit_element], "Edit request script", Some("Edit"))),
+                            EditRequestScriptSystemEditor(EventKeyBinding::new(vec![key_bindings.generic.list_and_table_actions.alt_edit_element], "Edit request script via system editor", None)),


"Same via system editor"

Julien-cpsn · 2025-12-26T21:35:46Z

The review above is just for me to remember what's to change!!
Good work tho

GachiLord · 2025-12-27T08:19:45Z

Hi, after using this for a while I noticed that provided VIM keybindings conflict with next_environment = "Shift-E".

IMHO there has to be a conflict detection mechanism to prevent this kind of situations

Julien-cpsn · 2025-12-27T09:07:32Z

Hello @GachiLord

Sorry I think that my previous comment got deleted.

I was asking if the system editor could be a config option rather than a keybinding.

Like you put use_system_editor = true in the config file. The advantage is that you don't have to use a specific keybinding each time, the "drawback" is that you always have to use the system editor

What do you think of this? I was just wondering of this being more practical, but I am not a user of this feature

I think your PR is great but I need to work on it to make it better

Btw the reviews are just for me to remember what needs to change

Have a great day

GachiLord · 2025-12-27T09:21:30Z

Yeah, your idea sounds great, though it's a lot more code to change. Guess I can rework the PR or create new one to implement this feature.

What do you think?

Julien-cpsn · 2025-12-27T09:32:27Z

@GachiLord you've done enough work, I will work on it

If you have any requests or comments to add, go on!

GachiLord · 2025-12-27T09:41:13Z

I think there is nothing to add. Looking forward to new release!

Julien-cpsn · 2026-02-01T23:40:59Z

Added in 4ad3277

GachiLord added 6 commits September 27, 2025 12:23

add edit dep

d3eb8a3

add ability to modify request body via system's editor

268dd17

add alt_edit_element keybinding for system's editor

8b9833b

add system editor to request scripts

a714b07

add system editor to request urls

ea820dd

fix typos in word 'extension'

9ea3b36

Julien-cpsn requested changes Dec 26, 2025

View reviewed changes

Julien-cpsn reviewed Dec 26, 2025

View reviewed changes

preiter93 mentioned this pull request Jan 9, 2026

feat: Add support for open system editor preiter93/edtui#48

Merged

Julien-cpsn closed this Feb 1, 2026

		use crate::tui::utils::stateful::text_input::TextInput;


		pub fn run(terminal: &mut Terminal<impl Backend>, default_text: &str, file_extension: &str) -> Result<String> {

Uh oh!

Conversation

GachiLord commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's new

What's changed

Testing

Uh oh!

Julien-cpsn commented Sep 28, 2025

Uh oh!

Julien-cpsn commented Sep 28, 2025

Uh oh!

GachiLord commented Sep 28, 2025

Uh oh!

Rimann91 commented Nov 18, 2025

Uh oh!

Julien-cpsn commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julien-cpsn commented Dec 26, 2025

Uh oh!

GachiLord commented Dec 27, 2025

Uh oh!

Julien-cpsn commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GachiLord commented Dec 27, 2025

Uh oh!

Julien-cpsn commented Dec 27, 2025

Uh oh!

GachiLord commented Dec 27, 2025

Uh oh!

Julien-cpsn commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GachiLord commented Sep 28, 2025 •

edited

Loading

Julien-cpsn commented Nov 19, 2025 •

edited

Loading

Julien-cpsn commented Dec 27, 2025 •

edited

Loading