Add Workflow#12
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a GitHub Actions CI workflow and updates the project/code to match newer Plugin-SDK/VS2022-era APIs and build settings.
Changes:
- Add a Windows CI workflow that checks out
plugin-sdkand builds the solution. - Update project settings to VS2022 toolset (v143), updated include paths/defines, and latest C++ language mode.
- Update various Plugin-SDK field/member accesses (e.g.,
bInVehicle,m_eWeaponType,bEngineOn, handling flags).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
MixSets/ReadIni.cpp |
Updates various Plugin-SDK field names (vehicle/ped/weapon/camera-related). |
MixSets/MixSets.vcxproj |
Moves to v143 toolset and adjusts include/defines and language standard. |
MixSets/MixSets.cpp |
Updates Plugin-SDK field access and minor pointer checks/flags usage. |
MixSets/IMFX/imfx.h |
Updates RenderWare include to match new include directories. |
MixSets/IMFX/Gunflashes.cpp |
Updates weapon slot/type usage and in-vehicle checks. |
.github/workflows/ci.yml |
Adds CI pipeline for building plugin-sdk + MixSets on Windows runners. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:34
- Step name typo: "Build plugin-sd" should likely be "Build plugin-sdk" to avoid confusion when reading CI logs.
- name: Build plugin-sd
shell: cmd
run: msbuild "%PLUGIN_SDK_DIR%\plugin.sln" /p:Configuration=Release /p:Platform="Mixed Platforms" /t:plugin_sa /m
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bool __fastcall Gunflashes::MyProcessUseGunTask(CTaskSimpleUseGun *task, int, CPed *ped) { | ||
| if (task->m_pWeaponInfo == CWeaponInfo::GetWeaponInfo(ped->m_aWeapons[ped->m_nActiveWeaponSlot].m_nType, ped->GetWeaponSkill())) { | ||
| if (task->m_pWeaponInfo == CWeaponInfo::GetWeaponInfo(ped->m_aWeapons[ped->m_nSelectedWepSlot].m_eWeaponType, ped->GetWeaponSkill())) { |
There was a problem hiding this comment.
This compares against weapon info for m_nSelectedWepSlot, but passes ped->GetWeaponSkill() (no weapon-type argument). Later in this file you call GetWeaponSkill(weaponType), so this line may select the wrong CWeaponInfo for some weapons/skills. Use the weapon-type-specific overload here too for consistency/correctness.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
No description provided.