Fix for UnboundLocalError: cannot access local variable 'resp' ...#822
Open
andyjsharp wants to merge 6 commits into
Open
Fix for UnboundLocalError: cannot access local variable 'resp' ...#822andyjsharp wants to merge 6 commits into
andyjsharp wants to merge 6 commits into
Conversation
Fix for UnboundLocalError: cannot access local variable 'resp' ...
UnboundLocalError: cannot access local variable 'resp' ...
Fix for file-delete rpc when resp is None
PEP8 fix
Update rpc.py and fix PEP8 checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in issue #821, running the file-delete RPC can return module failure output that includes:
No start of json char foundUnboundLocalError: cannot access local variable 'resp' ...This pull request fixes both issues by initializing
respbefore RPC execution.In addition, some RPC operations such as
file-deletemay return an empty reply body. Previously this could lead toUnexpected response type <class 'NoneType'>. This change adds explicit handling for an emptyfile-deletereply so the task is treated as successful, without requiringfailed_when: false.Using the playbook from issue #821, with the following playbook change:
The playbook now runs without failures: