feat: default trigger to store ts-input-packets-pps ts-output-packets-pps to tsdb - #1043
Conversation
|
@vvikramb, @gaddevijay, @sanjeevm-jsi Please review. |
| field ts-drop-packets-pps { | ||
| formula { | ||
| eval { | ||
| expression "($ts-input-packets-pps - $ts-output-packets-pps) * (($ts-input-packets-pps - $ts-output-packets-pps) > 0)"; |
There was a problem hiding this comment.
How does this give drop pps? I don't think this is an accurate calculation
There was a problem hiding this comment.
I wanted the calculate max((ts-input-packets-pps - ts-output-packets-pps), 0) to achieve this I added such expression.
Also this is an outdated change, not part of the PR now as we are calculating this elsewhere.
| expression "($ts-input-packets-pps - $ts-output-packets-pps) * (($ts-input-packets-pps - $ts-output-packets-pps) > 0)"; | ||
| } | ||
| } | ||
| type unsigned-integer; |
There was a problem hiding this comment.
We don't store unsigned integer
There was a problem hiding this comment.
I saw this being used for other fields (
) and as this was being derived from those fields I used the same type.Also this is an outdated change, not part of the PR now.
| type string; | ||
| description "FPC name"; | ||
| } | ||
| trigger pfe-input-output-stats { |
There was a problem hiding this comment.
Why does this look like a dummy trigger to me? Is AIML consuming any trigger data?
There was a problem hiding this comment.
Why this needs to be stored? What is the purpose of this?
There was a problem hiding this comment.
Yes, its a dummy commit as we wanted to store ts-input-packets-pps and ts-output-packets-pps to TSDB to plot the Traffic Loss graph (in Routing and MPLS accordion) in real time like we plot the graphs for Hardware and Interfaces accordion.
4 participants
Added a default trigger to store ts-input-packets-pps, ts-output-packets-pps and ts-drop-packets-pps in TSDB