Remove <empty string> from permitted freeform lag_mode values#1250
Open
chrismarget-j wants to merge 2 commits into
Open
Remove <empty string> from permitted freeform lag_mode values#1250chrismarget-j wants to merge 2 commits into
lag_mode values#1250chrismarget-j wants to merge 2 commits into
Conversation
chrismarget-j
force-pushed
the
1241-empty-string-input-in-apstra_freeform_aggregate_link
branch
from
d7fea47 to
b0a3bb7
Compare
chrismarget-j
force-pushed
the
1241-empty-string-input-in-apstra_freeform_aggregate_link
branch
from
b0a3bb7 to
ade759a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the option to configure
""(no LAG mode) within anapstra_freeform_aggregate_linkresource.Previously, the permitted modes were:
"""lacp_active""lacp_passive""static_lag"Now it's just:
"lacp_active""lacp_passive""static_lag"Setting the empty string (no LAG) doesn't really make sense when the point of the resource is to create a LAG.
Closes #1241