Update Pester tests for new C# project structure; fix code review issues

Co-authored-by: JustinGrote <15258962+JustinGrote@users.noreply.github.com>
Agent-Logs-Url: https://github.com/JustinGrote/ModuleFast/sessions/eac9df56-fca6-48d7-8e04-c899cdbbb277

Author: Copilot

ModuleFast.psd1

@@ -72,7 +72,7 @@
     FunctionsToExport = 'Install-ModuleFast', 'Get-ModuleFastPlan', 'Clear-ModuleFastCache'
 
     # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
-    CmdletsToExport   = 'Get-ModuleFastPlan', 'Clear-ModuleFastCache'
+    CmdletsToExport   = @()
 
     # Variables to export from this module
     #VariablesToExport = '*'

ModuleFast.psm1

@@ -30,6 +30,13 @@ if (Test-Path $binaryModulePath) {
     if (-not $accelerators::Get.ContainsKey('ModuleFastInfo')) {
         $accelerators::Add('ModuleFastInfo', [ModuleFast.ModuleFastInfo])
     }
+
+    # Clean up type accelerators when this module is removed
+    $MyInvocation.MyCommand.ScriptBlock.Module.OnRemove = {
+        $accelerators = [psobject].Assembly.GetType('System.Management.Automation.TypeAccelerators')
+        $accelerators::Remove('ModuleFastSpec')
+        $accelerators::Remove('ModuleFastInfo')
+    }
 }
 
 #Because we are changing state, we want to be safe

ModuleFast.tests.ps1

@@ -3,76 +3,78 @@ using namespace Microsoft.PowerShell.Commands
 using namespace System.Collections.Generic
 using namespace System.Diagnostics.CodeAnalysis
 using namespace NuGet.Versioning
+using namespace ModuleFast
 
-. $PSScriptRoot/ModuleFast.ps1 -ImportNuGetVersioning
-Import-Module $PSScriptRoot/ModuleFast.psm1 -Force
+Import-Module $PSScriptRoot/ModuleFast.psd1 -Force
 
 BeforeAll {
   if ($env:MFURI) {
     $PSDefaultParameterValues['*-ModuleFast*:Source'] = $env:MFURI
   }
 }
 
-InModuleScope 'ModuleFast' {
-  Describe 'ModuleFastSpec' {
-    Context 'Constructors' {
-      It 'Getters' {
-        $spec = [ModuleFastSpec]'Test'
-        'Name', 'Guid', 'Min', 'Max', 'Required' | ForEach-Object {
-          $spec.PSObject.Properties.name | Should -Contain $PSItem
-        }
+# ModuleFastSpec is a public C# class — no InModuleScope needed
+Describe 'ModuleFastSpec' {
+  Context 'Constructors' {
+    It 'Getters' {
+      $spec = [ModuleFastSpec]'Test'
+      'Name', 'Guid', 'Min', 'Max', 'Required' | ForEach-Object {
+        $spec.PSObject.Properties.name | Should -Contain $PSItem
       }
+    }
 
-      It 'Name' {
-        $spec = [ModuleFastSpec]'Test'
-        $spec.Name | Should -Be 'Test'
-        $spec.Guid | Should -Be ([Guid]::Empty)
-        $spec.Min | Should -BeNull
-        $spec.Max | Should -BeNull
-        $spec.Required | Should -BeNull
-      }
+    It 'Name' {
+      $spec = [ModuleFastSpec]'Test'
+      $spec.Name | Should -Be 'Test'
+      $spec.Guid | Should -Be ([Guid]::Empty)
+      $spec.Min | Should -BeNull
+      $spec.Max | Should -BeNull
+      $spec.Required | Should -BeNull
+    }
 
-      It 'Has non-settable properties' {
-        $spec = [ModuleFastSpec]'Test'
-        { $spec.Min = '1' } | Should -Throw
-        { $spec.Max = '1' } | Should -Throw
-        { $spec.Required = '1' } | Should -Throw
-        { $spec.Name = 'fake' } | Should -Throw
-        { $spec.Guid = New-Guid } | Should -Throw
-      }
+    It 'Has non-settable properties' {
+      $spec = [ModuleFastSpec]'Test'
+      { $spec.Min = '1' } | Should -Throw
+      { $spec.Max = '1' } | Should -Throw
+      { $spec.Required = '1' } | Should -Throw
+      { $spec.Name = 'fake' } | Should -Throw
+      { $spec.Guid = New-Guid } | Should -Throw
+    }
 
-      It 'ModuleSpecification' {
-        $in = [ModuleSpecification]@{
-          ModuleName    = 'Test'
-          ModuleVersion = '2.1.5'
-        }
-        $spec = [ModuleFastSpec]$in
-        $spec.Name | Should -Be 'Test'
-        $spec.Guid | Should -Be ([Guid]::Empty)
-        $spec.Min | Should -Be '2.1.5'
-        $spec.Max | Should -BeNull
-        $spec.Required | Should -BeNull
+    It 'ModuleSpecification' {
+      $in = [ModuleSpecification]@{
+        ModuleName    = 'Test'
+        ModuleVersion = '2.1.5'
       }
+      $spec = [ModuleFastSpec]$in
+      $spec.Name | Should -Be 'Test'
+      $spec.Guid | Should -Be ([Guid]::Empty)
+      $spec.Min | Should -Be '2.1.5'
+      $spec.Max | Should -BeNull
+      $spec.Required | Should -BeNull
     }
+  }
 
-    Context 'ModuleSpecification Conversion' {
-      It 'Name' {
-        $spec = [ModuleSpecification][ModuleFastSpec]'Test'
-        $spec.Name | Should -Be 'Test'
-        $spec.Version | Should -Be '0.0'
-        $spec.RequiredVersion | Should -BeNull
-        $spec.MaximumVersion | Should -BeNull
-      }
-      It 'RequiredVersion' {
-        $spec = [ModuleSpecification][ModuleFastSpec]::new('Test', '1.2.3')
-        $spec.Name | Should -Be 'Test'
-        $spec.RequiredVersion | Should -Be '1.2.3.0'
-        $spec.Version | Should -BeNull
-        $spec.MaximumVersion | Should -BeNull
-      }
+  Context 'ModuleSpecification Conversion' {
+    It 'Name' {
+      $spec = [ModuleSpecification][ModuleFastSpec]'Test'
+      $spec.Name | Should -Be 'Test'
+      $spec.Version | Should -Be '0.0'
+      $spec.RequiredVersion | Should -BeNull
+      $spec.MaximumVersion | Should -BeNull
+    }
+    It 'RequiredVersion' {
+      $spec = [ModuleSpecification][ModuleFastSpec]::new('Test', '1.2.3')
+      $spec.Name | Should -Be 'Test'
+      $spec.RequiredVersion | Should -Be '1.2.3.0'
+      $spec.Version | Should -BeNull
+      $spec.MaximumVersion | Should -BeNull
     }
   }
+}
 
+# Import-ModuleManifest is a private PS function — InModuleScope required
+InModuleScope 'ModuleFast' {
   Describe 'Import-ModuleManifest' {
     It 'Reads Dynamic Manifest' {
       $Mocks = "$PSScriptRoot/Test/Mocks"

src/ModuleFast/Commands/ClearModuleFastCacheCommand.cs

@@ -5,13 +5,13 @@ namespace ModuleFast;
 
 public static class ModuleFastClient
 {
-    public static HttpClient Create(string? credential = null, int timeoutSeconds = 30)
+    public static HttpClient Create(int timeoutSeconds = 30)
     {
         var handler = new SocketsHttpHandler
         {
             MaxConnectionsPerServer = 10,
             InitialHttp2StreamWindowSize = 16777216,
-            AutomaticDecompression = DecompressionMethods.All
+            AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate | DecompressionMethods.Brotli
         };
         var client = new HttpClient(handler)
         {

src/ModuleFast/Commands/GetModuleFastPlanCommand.cs

@@ -227,7 +227,7 @@ public bool SatisfiedBy(NuGetVersion version, bool strictSemVer)
     public bool Overlap(VersionRange other)
     {
         var subset = VersionRange.CommonSubSet(new List<VersionRange> { _versionRange, other });
-        return subset.ToString() != "(0.0.0, 0.0.0)";
+        return !subset.Equals(VersionRange.None);
     }
 
     // --- Interface implementations ---
@@ -263,8 +263,8 @@ public int CompareTo(object? other)
         }
 
         if (_versionRange.Satisfies(version!)) return 0;
-        if (_versionRange.MinVersion != null && _versionRange.MinVersion > version) return 1;
-        if (_versionRange.MaxVersion != null && _versionRange.MaxVersion < version) return -1;
+        if (_versionRange.MinVersion != null && _versionRange.MinVersion > version!) return 1;
+        if (_versionRange.MaxVersion != null && _versionRange.MaxVersion < version!) return -1;
         throw new InvalidOperationException("Could not compare. This is a bug.");
     }