Configure MTU via peripheral builder#867
Open
twyatt wants to merge 7 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bce7bae. Configure here.
QuantumRand
reviewed
Jul 21, 2026
| ) | ||
|
|
||
| suspendUntil<State.Connecting.Services>() | ||
| if (desiredMtu != null) requestMtu(desiredMtu) |
Contributor
There was a problem hiding this comment.
If requestMtu() fails at this point (throwing GattRequestRejectedException), is it cancelling the connection? Shouldn't it be able to continue the connection with the default MTU?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #811
Note
Medium Risk
Breaking API removal and new default MTU on every connect change connection timing and permission requirements; write chunk sizing behavior changes on newer Android versions due to the attribute-length cap.
Overview
Android MTU is now configured on the peripheral builder instead of calling
requestMtuduringonServicesDiscoveredor onAndroidPeripheral. NewPeripheralBuilder.mtudefaults to 517 (nullskips any MTU request); the library requests MTU after GATT connect and before service discovery.Breaking: public
AndroidPeripheral.requestMtuandServicesDiscoveredPeripheral.requestMtuare removed.connect()docs noteBLUETOOTH_CONNECTwhen MTU is non-null.maximumWriteValueLengthForTypeis capped by Android max attribute length (512 on API 33+, 600 on older APIs).Reviewed by Cursor Bugbot for commit bce7bae. Configure here.