Add support for mailto, sms, and tel schemes.#305
Open
Phoenix7351 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6afb6d9. Configure here.
Phoenix7351
marked this pull request as ready for review
July 16, 2026 21:09
mailto, sms, and tel schemes.
davertay-j
requested changes
Jul 17, 2026
davertay-j
left a comment
Collaborator
There was a problem hiding this comment.
The new logic is just shuffling around conditionals that already exist at the callsite. The logic change should be isolated solely to the createWebViewWith callback.
davertay-j
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes an issue where common non-http(s) schemes (
mailto,tel,sms) did nothing when tapped.Note
Low Risk
Localized navigation-handoff change with tests; behavior is limited to opening external URLs outside the web view.
Overview
External URL schemes (
mailto:,tel:,sms:, and any non–web-navigable scheme) are now opened via the OS instead of being dropped or only handled on the main navigation path.URLgainsshouldDelegateToSystem(anything with a scheme that is not http/https/about/data/blob) and the in-webview scheme check is renamed toisWebNavigableScheme. Unsupported navigations still cancel in the web view, but opening is centralized indelegateURLToSystem, which usesUIApplication.shared.openon iOS andNSWorkspace.shared.openon macOS, with a shared denial callback for logging.New-window navigations (
WKUIDelegate) now use the same delegation when the target URL is a system scheme, so links likemailto:opened in a new window are handled like normal link taps. Tests cover scheme classification and thatNavigationRequestis nil formailto:actions.Reviewed by Cursor Bugbot for commit 6afb6d9. Configure here.