Refactor the converter table in Texture2DConverter #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
CONV_TABLE
and it related code.{ TF -> (function, arg1, arg2, ...) }
{ TF -> (function, (arg1, arg2, ...)) }
This PR also:
CONV_TABLE
whereEAC_R:SIGNED
should beEAC_R_SIGNED
.fmt
argument ofetc
function to maintain consistency witheac
.Rationality
Clearly separate function and its additional arguments.
Resolves
typing_extensions
import error.In 035cb09 ,
typing_extensions
package has been introduced toTexture2DConverter
to provide theUnpack
type hint. However, this package is not a standard library, so it is not installed in some Python environments, causingModuleNotFoundError
. Adding this package to UnityPy's dependencies explicitly can solve this error, but it is not worth it.