Enhance Dockerfile to make it build and run in a container #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is a contribution to issue #384 |
stoch
approved these changes
Oct 8, 2019
Contributor
stoch
left a comment
stoch
left a comment
There was a problem hiding this comment.
Let's include this 'from scratch' approach for building a docker instance but also follow the alternative approach of using a versioned erlang docker image as a basis. Both approaches have their advantages, depending on the exact requirements.
c-bik
requested changes
Oct 8, 2019
| # dderl opts | ||
| dderl_opts="-dderl" | ||
| dderl_opts=$dderl_opts" port $dderlport" | ||
| dderl_opts=$dderl_opts" interface \"0.0.0.0\" port $dderlport" |
Member
There was a problem hiding this comment.
In #629 (review) PR default interface are changed to 0.0.0.0 where the env variables are declared. Which makes this redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings from Hackergarten :-)