Skip to content

Create jobs for soap one way operations with kdwsdl2cpp#312

Merged
dfaure-kdab merged 4 commits into
KDAB:masterfrom
jtjbrady:master
Jun 19, 2025
Merged

Create jobs for soap one way operations with kdwsdl2cpp#312
dfaure-kdab merged 4 commits into
KDAB:masterfrom
jtjbrady:master

Conversation

@jtjbrady

Copy link
Copy Markdown
Contributor

Create classes for SOAP OneWayOperations, fixes #311

Additionally don't use deprecated Qt features - should be able to compile KDSoap with QT_DISABLE_DEPRECATED_BEFORE=0x060900 / QT_DISABLE_DEPRECATED_UP_TO=0x060900.
libkode still uses one deprecated function in schema/parser.cpp

@dfaure-kdab dfaure-kdab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the datetime stuff would be in a separate branch, for a separate PR, but I don't want to nitpick too much, it all looks quite fine.

After cleaning up the test cpp file that part can go in, and I'm interested in your thoughts about ditching KDDateTime completely (but of course I'm also OK with just merging the bugfix and moving on).

Comment thread unittests/kdwsdl2cpp_jobs/test_jobs.cpp Outdated
Comment thread unittests/kddatetime/test_kddatetime.cpp
@dfaure-kdab

Copy link
Copy Markdown
Member

I'll take care of the issues in README.md which trigger the pre-commit errors.

@dfaure-kdab

Copy link
Copy Markdown
Member

I'll take care of the issues in README.md which trigger the pre-commit errors.

Done (#313), please rebase.

@dfaure-kdab

Copy link
Copy Markdown
Member

Flaky test, but I don't know how to trigger another CI run...
@dantti ?

@dfaure-kdab

Copy link
Copy Markdown
Member

@jtjbrady please rebase once more (if you do an actual rebase, get rid of the merge commits, and force-push, then the rebase button here will work, otherwise you have to merge by hand every time), now that my other MR is merged. This will trigger CI again.

@dfaure-kdab

Copy link
Copy Markdown
Member

Something went wrong with the rebase, now the PR includes my own commits (and still some merge commits).
I suggest git fetch ; git rebase -i origin/master
and deleting every line that shouldn't be part of this PR.

@dfaure-kdab

Copy link
Copy Markdown
Member

Almost there:

test_wsusernametoken.cpp:44:116: error: incomplete type ‘QTimeZone’ used in nested name specifier

@jtjbrady

Copy link
Copy Markdown
Contributor Author

Hmmm, works with 6.8.3. I guess I'll install 6.5 and recompile.
I'm guessing it just needs a #include at the top of the file.

@dfaure-kdab

Copy link
Copy Markdown
Member

Yeah, just add an include, don't bother testing locally, the CI will tell us ;)

@jtjbrady

Copy link
Copy Markdown
Contributor Author

Yeah, just add an include, don't bother testing locally, the CI will tell us ;)

I wish I'd read that first, before installing Qt 6.5.9.

@dfaure-kdab
dfaure-kdab merged commit ad19cb3 into KDAB:master Jun 19, 2025
27 checks passed
@dantti

dantti commented Jun 26, 2025

Copy link
Copy Markdown
Member

@dfaure-kdab sorry missed the ping, to run CI jobs again go to "checks" tab then you should see a button labeled "Re-run all jobs".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kdwsdl2cpp does not create jobs for calls with no output

3 participants