Create jobs for soap one way operations with kdwsdl2cpp#312
Conversation
dfaure-kdab
left a comment
There was a problem hiding this comment.
Ideally the datetime stuff would be in a separate branch, for a separate PR, but I don't want to nitpick too much, it all looks quite fine.
After cleaning up the test cpp file that part can go in, and I'm interested in your thoughts about ditching KDDateTime completely (but of course I'm also OK with just merging the bugfix and moving on).
|
I'll take care of the issues in README.md which trigger the pre-commit errors. |
Done (#313), please rebase. |
|
Flaky test, but I don't know how to trigger another CI run... |
|
@jtjbrady please rebase once more (if you do an actual rebase, get rid of the merge commits, and force-push, then the rebase button here will work, otherwise you have to merge by hand every time), now that my other MR is merged. This will trigger CI again. |
|
Something went wrong with the rebase, now the PR includes my own commits (and still some merge commits). |
|
Almost there:
|
|
Hmmm, works with 6.8.3. I guess I'll install 6.5 and recompile. |
|
Yeah, just add an include, don't bother testing locally, the CI will tell us ;) |
I wish I'd read that first, before installing Qt 6.5.9. |
|
@dfaure-kdab sorry missed the ping, to run CI jobs again go to "checks" tab then you should see a button labeled "Re-run all jobs". |
Create classes for SOAP OneWayOperations, fixes #311
Additionally don't use deprecated Qt features - should be able to compile KDSoap with QT_DISABLE_DEPRECATED_BEFORE=0x060900 / QT_DISABLE_DEPRECATED_UP_TO=0x060900.
libkode still uses one deprecated function in schema/parser.cpp