Add shorthand for cxx_qt::Initialize #1242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12612 12634 +22
=========================================
+ Hits 12612 12634 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenFordTytherington
force-pushed
the
add-init-alias
branch
from
420695f to
e53a9f5
Compare
Collaborator
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Works well, but is missing a bit of documentation.
Please also update e.g. qml_features to use the shorthand where appropriate.
BenFordTytherington
force-pushed
the
add-init-alias
branch
4 times, most recently
from
946ba2a to
2f3911f
Compare
BenFordTytherington
force-pushed
the
add-init-alias
branch
2 times, most recently
from
e3c39d4 to
61935f4
Compare
- `impl cxx_qt::Initialize for x {}` can now be written in the bridge as shorthand
- It is shorthand for `impl cxx_qt::Constructor<()> for x {}`
- Update book, qml_features and docs
ahayzen-kdab
force-pushed
the
add-init-alias
branch
from
61935f4 to
533dff7
Compare
LeonMatthesKDAB
added
the
⏮️ backport-candidate
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl cxx_qt::Initialize for x {}can now be written in the bridge as shorthandimpl cxx_qt::Constructor<()> for x {}impl cxx_qt::Initialize for X {}as shorthand forimpl cxx_qt::Constructor<()> for X {}#1236