Place all objects and passthrough items in the same block, to pass th…#1282
Place all objects and passthrough items in the same block, to pass th…#1282BenFordTytherington wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1282 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12777 +5
=========================================
+ Hits 12772 12777 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@BenFordTytherington what is the use-case for this, especially the An extern block is not a module, so does the documentation even end up anywhere readable? |
7f256a6 to
fac4c0d
Compare
c831813 to
e94f57a
Compare
|
This seemed like too much of a task, to reorganise code placement in generated output, just for the sake of it, as I had hoped some minor changes could make things easier to place in the same output. I had hoped this would allow for putting cfg attributes on the block, and passing them through to generation more easily, but I think this is not the way, so will close. |
Ultimately, it would be good to preserve the blocks things appear in, so if you place a cfg or doc attribute on the top of a block, it is preserved in the final code, but this requires significant rewriting, so work is beginning by slowly grouping things into the same extern block, and passing through docs.