Implement From<T> for types that implements From<&T> and Into<T>, and vice versa #1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an odd pattern across many files that looks like this:
One of the implementations uses a borrow, and the other one does not, even though both are calling functions that take references. Theoretically, in order to be consistent with Qt, both implementations should use borrowing (
From<&QLine>andFrom<&QLineF>). But I don't think it would make sense to remove the by-value implementations, because A) that would be a breaking change, and B) it is useful to be able to do e.g.let pointf = QPoint::new(1, 2).into()rather thanlet pointf = (&QPoint::new(1, 2)).into(). So instead, I just added complementary implementations so nowFrom<QLine> for QLineFandFrom<&QLineF> for QLineare implemented as well.That said, I'm not sure why
QPenimplementsFrom<&PenStyle>. I added an implementation forFrom<PenStyle>, so that part is handled, but at some point it might be worth removing theFrom<&PenStyle>implementation, becausePenStyleis just ani32enum. There's no point in passing it by reference rather than value.