Use usize in QAnyStringView layout instead of c_void#1400
Open
Use usize in QAnyStringView layout instead of c_void#1400
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13124 13124
=========================================
Hits 13124 13124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QAnyStringViewcontains a const void pointer, but the correct representation for the size of a const void pointer isMaybeUninit<usize>, notMaybeUninit<[c_void; 1]>. The size ofc_voidis an implementation detail from the cxx library, and should not be used for layout calculations.c_voidis an opaque extern, which means it's only ever passed around by reference, so its size does not need to be defined.