Skip to content

Fix the #[qenum] attribute breaking compilation#1420

Open
jnbooth wants to merge 2 commits intoKDAB:mainfrom
jnbooth:fix-qenum
Open

Fix the #[qenum] attribute breaking compilation#1420
jnbooth wants to merge 2 commits intoKDAB:mainfrom
jnbooth:fix-qenum

Conversation

@jnbooth
Copy link
Contributor

@jnbooth jnbooth commented Feb 23, 2026

For some reason, adding #[qenum(MyType)] to an enum inside of cxx_qt::bridge changes its visibility from pub to pub(super). This causes compilation errors such as "type mytype::cxx_qt_private_qenum_MyEnum::MyEnum is private" if you try to use that enum anywhere outside of the file in which it is declared. This PR changes the visibility from pub(super) to pub, fixing the issue.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (df0b5b3) to head (a6a1444).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1420   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines        13457     13455    -2     
=========================================
- Hits         13457     13455    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahayzen-kdab ahayzen-kdab added the ⏮️ backport-candidate Change which could be backported to the stable series label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⏮️ backport-candidate Change which could be backported to the stable series

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants