Implement PartialEq<[u8]> for QByteArray and PartialEq<str> for QString#1446
Open
jnbooth wants to merge 3 commits into
Open
Implement PartialEq<[u8]> for QByteArray and PartialEq<str> for QString#1446jnbooth wants to merge 3 commits into
PartialEq<[u8]> for QByteArray and PartialEq<str> for QString#1446jnbooth wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13455 13455
=========================================
Hits 13455 13455 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+250
to
+254
| impl PartialEq<str> for QString { | ||
| fn eq(&self, other: &str) -> bool { | ||
| self.as_slice().iter().copied().eq(other.encode_utf16()) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
hmm wonder if we want this one, as most of the time the API ends up being explicit about when there is a copy or conversion to/from utf16 or runtime cost ? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Qt, you can test equality for QByteArrays and QStrings against raw data without needing to allocate memory, e.g.
QStringLiteral("test") == "test". This PR makes it possible to do the same in Rust by implementingPartialEqfor the corresponding types.