Implement QVariantValue for QList<QString> - #1482
Merged
Merged
Conversation
yuknig
force-pushed
the
qlist_qstring_qvariantvalue
branch
from
August 16, 2026 19:59
88ebb22 to
ccd6fe5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13484 13484
=========================================
Hits 13484 13484 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
These additional arguments are needed to make the script work with non-primitive types.
Although QStringList already has an implementation, QList<QString> and QStringList are distinct types in Qt 5 and require separate implementations.
yuknig
force-pushed
the
qlist_qstring_qvariantvalue
branch
from
August 16, 2026 21:59
ccd6fe5 to
b7ddeea
Compare
ahayzen-kdab
approved these changes
Aug 17, 2026
ahayzen-kdab
left a comment
ahayzen-kdab
left a comment
Collaborator
There was a problem hiding this comment.
LGTM and tests seem to pass for both Qt 5 and Qt 6. Assume there isn't any confusion between QList and QStringList when you retrieve on the Rust side as they are an alias in Qt 6 so the "same" anyway, it's only Qt 5 where this can be fun ?
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
QVariantValueimplementation forQList<QString>.QStringListalready has an implementation, but in Qt 5QStringListis a subclass ofQList<QString>but not an alias for it. So, these two are distinct types and each needs its own implementation.