Skip to content

cxx-qt-lib: harden conversion of QObjectMutPtr from / to raw pointer. - #1486

Merged
ahayzen-kdab merged 1 commit into
KDAB:mainfrom
yuknig:qobject_ptr_unsafe
Aug 21, 2026
Merged

cxx-qt-lib: harden conversion of QObjectMutPtr from / to raw pointer.#1486
ahayzen-kdab merged 1 commit into
KDAB:mainfrom
yuknig:qobject_ptr_unsafe

Conversation

@yuknig

@yuknig yuknig commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Replace From trait implementations with dedicated conversion methods to make raw pointer conversions a bit more explicit.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (91526d9) to head (5ba284c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines        13484     13484           
=========================================
  Hits         13484     13484           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread crates/cxx-qt-lib/src/core/qobjectmutptr.rs
Replace `From` trait implementations with dedicated conversion methods to make raw pointer conversions a bit more explicit.
@yuknig
yuknig force-pushed the qobject_ptr_unsafe branch from 7987402 to 5ba284c Compare August 21, 2026 12:56

@ahayzen-kdab ahayzen-kdab left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab
ahayzen-kdab added this pull request to the merge queue Aug 21, 2026
Merged via the queue into KDAB:main with commit a733e34 Aug 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants