security: remediate 2026-06 review findings across ai/api/go - #1
Merged
Conversation
- core/supabase_client.py: service-role PostgREST + storage + rpc client. - dependencies/firm.py: verify_supabase_jwt (Supabase UUID identity, pinned exp/iss/aud), firm resolution + membership checks. - routers/sync.py: desktop->dashboard finding ingestion, per-firm upsert idempotency, staleness guard, evidence signed upload, optional shared engagement routing. - routers/firms.py + schemas/firms.py: firms CRUD, members, opsec invite links (hashed/single-use/expiring/email-bind), engagements. - dependencies/entitlement.py: $499 platform gate via get_user_access_level web_dashboard feature, seat model (firm-owner entitlement), 402 on miss. - register firms_router + sync_router; config: supabase_jwt_secret, webapp_url, dashboard_required_feature. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Apply Critical/High/Medium fixes from the security audit: - AI: command-injection guard on tool name + target (C-04), scope validation, secret backend via keyring, secure file open with O_NOFOLLOW, scanner safety controls - API: token-hash quota check (C-02), proxy-trust CIDR (H-02), JWT secret strength enforcement (H-07), AI endpoint scoping (M-10) - Go: MSF client TLS verify-by-default w/ MSF_INSECURE_TLS opt-in (M-05), licensing gates documented as intentional no-ops (M-18), loot manager nofollow open flags, disk-space platform splits Add regression tests (Python + Go) and locked AI test env setup. All four test suites pass via run_all_tests.sh --ci. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates Critical/High/Medium findings from the 2026-06 security review across all three codebases. All four test suites pass via
run_all_tests.sh --ci.Changes
MSF_INSECURE_TLSopt-in (M-05), licensing gates documented as intentional no-ops (M-18), loot nofollow open flags, disk-space platform splitsTests
run_all_tests.sh --ci: API ✓ AI ✓ Go ✓ Integration ✓ (58s)🤖 Generated with Claude Code