SpacemouseKeys module

[Glodigit]

This is a chunk of #1087 for a module that

• Adds the 2 buttons found on a SpaceMouse Compact.
• Adds buttons for increasing/decreasing movement in the 6 axes.

PR dependencies: #1092

[xs5871]

I know this is basically a copy-paste of the mouse keys module, but having a dozen methods that all don't actually do anything except binding over a parameter is a terrible design pattern.
The movement direction should be an attribute of SpacemouseKey and we only need a single on_press and on_release.

[Glodigit]

So something like the below?

for n, names in enumerate(keys):
    make_key(
        names=names,
        on_press=self.on_press,
        on_release=self.on_release,
        constructor=SpacemouseKey,
        direction=1<<n
        )

or to use the existing .code?

for n, names in enumerate(keys):
    make_key(
        names=names,
        on_press=self.on_press,
        on_release=self.on_release,
        constructor=SpacemouseKey,
        code=0x80+n
        )

or would it be a new SpacemouseDirectionKey constructor to avoid unintended HID reports?

[xs5871]

The way it's implemented right now SpacemouseKey should only be used for buttons. I think axes need a now derived key class, i.e. a SpacemouseDirectionKey. You can still define that the same way as SpacemouseKey and assign the direction to .code.

[xs5871]

tiny nitpick:

Suggested change

	def _maybe_start_move(self, mask):
	self._movement |= mask
	if self._movement == mask:
	self._task.restart()
	def _maybe_stop_move(self, mask):
	self._movement &= ~mask
	if not self._movement:
	cancel_task(self._task)
	self._move_step = 0
	def _on_press(self, key, keyboard, *args, **kwargs):
	self._maybe_start_move(key.code)
	def _on_release(self, key, keyboard, *args, **kwargs):
	self._maybe_stop_move(key.code)
	def _on_press(self, key, keyboard, *args, **kwargs):
	self._movement |= key.code
	if self._movement == key.code:
	self._task.restart()
	def _on_release(self, key, keyboard, *args, **kwargs):
	self._movement &= ~key.code
	if not self._movement:
	cancel_task(self._task)
	self._move_step = 0