Cp10 #1111
Merged
Cp10 #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This will break compatibility with CircuitPython version < 9.
regicidalplutophage
approved these changes
Jun 5, 2025
lecrouch
reviewed
Aug 5, 2025
| _task_queue.push(t, ticks_add(ticks_ms(), after_ms)) | ||
| elif after_ms == 0: | ||
| _task_queue.push_head(t) | ||
| _task_queue.push(t) |
There was a problem hiding this comment.
@xs5871
I know this is old but FWIW, this was a breaking change and I was running CircuitPython v 8.2.10. Upgraded to Beta 10 and it works.
Getting started docs say CPv7.3+ are compatible 🤷♂️
Was a bit of a bear to find, but big thank you to putting that it was a breaking change in the commit 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for CircuitPython 10.
It's also time to bump up the required CP version. KMK didn't support v7 for a while, and I think we only just barely support v8. I may be wrong, please correct me.