-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container #15
base: master
Are you sure you want to change the base?
Docker container #15
Conversation
Hey, thanks for the contribution but I'm not sure if it would be very useful, mind sharing your opinion? |
As I mentioned, this is useful when you want to use this application on a system which may not have node/npm installed, but does have a docker runtime. You can easily use this in a single command without having to install any software. With the |
Was hoping for something like this, tested it on my server and it works great! |
Can Multiarch support be added? |
I used a distroless image as a base for performance and security. There is a discussion about multi-arch support here: GoogleContainerTools/distroless#346. Once this happens, it should filter upstream to this image. |
This is perfect ffor speedtesting K8s on-prem nodes and my swarm of Flatcar linux vms |
I see someone posted up a docker version of this at https://hub.docker.com/r/p3terx/speed-cloudflare |
@@ -23,3 +23,7 @@ | |||
```bash | |||
npx speed-cloudflare-cli | |||
``` | |||
or | |||
```bash | |||
docker run --rm ghcr.io/luc122c/speed-cloudflare-cli:master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if/when ready to merge, this probably needs to be renamed for the target repo this links to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow file pushes to github.repository
so currently, it publishes to my fork. You're correct that when merging, it would need updating to the new location.
Hi there. I found myself wanting to use this on a number of machines which all had docker installed. I quickly build your script into a distroless docker container. I've also setup a Github action to publish it as a package so it's available more widely.