-
Notifications
You must be signed in to change notification settings - Fork 7
feat: apply color 1.0 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Reviewer's Guide by SourceryThis pull request introduces a new color system that supports light and high-contrast themes. It replaces the existing color definitions with a new structure in Updated class diagram for ColorThemeMode and colorsclassDiagram
class ColorThemeMode {
<<enumeration>>
light
high-contrast
}
class colors {
'primary-5': ColorValues
'primary-10': ColorValues
'primary-20': ColorValues
'primary-30': ColorValues
'primary-40': ColorValues
'primary-50': ColorValues
'primary-60': ColorValues
'primary-70': ColorValues
'primary-80': ColorValues
'primary-90': ColorValues
'primary-95': ColorValues
'secondary-5': ColorValues
'secondary-10': ColorValues
'secondary-20': ColorValues
'secondary-30': ColorValues
'secondary-40': ColorValues
'secondary-50': ColorValues
'secondary-60': ColorValues
'secondary-70': ColorValues
'secondary-80': ColorValues
'secondary-90': ColorValues
'secondary-95': ColorValues
'gray-0': ColorValues
'gray-5': ColorValues
'gray-10': ColorValues
'gray-20': ColorValues
'gray-30': ColorValues
'gray-40': ColorValues
'gray-50': ColorValues
'gray-60': ColorValues
'gray-70': ColorValues
'gray-80': ColorValues
'gray-90': ColorValues
'gray-95': ColorValues
'gray-100': ColorValues
'alpha-black100': ColorValues
'alpha-black75': ColorValues
'alpha-black50': ColorValues
'alpha-black25': ColorValues
'alpha-black10': ColorValues
'alpha-black0': ColorValues
'alpha-white100': ColorValues
'alpha-white75': ColorValues
'alpha-white50': ColorValues
'alpha-white25': ColorValues
'alpha-white10': ColorValues
'alpha-white0': ColorValues
'danger-5': ColorValues
'danger-10': ColorValues
'danger-20': ColorValues
'danger-30': ColorValues
'danger-40': ColorValues
'danger-50': ColorValues
'danger-60': ColorValues
'danger-70': ColorValues
'danger-80': ColorValues
'danger-90': ColorValues
'danger-95': ColorValues
'information-5': ColorValues
'information-10': ColorValues
'information-20': ColorValues
'information-30': ColorValues
'information-40': ColorValues
'information-50': ColorValues
'information-60': ColorValues
'information-70': ColorValues
'information-80': ColorValues
'information-90': ColorValues
'information-95': ColorValues
'warning-5': ColorValues
'warning-10': ColorValues
'warning-20': ColorValues
'warning-30': ColorValues
'warning-40': ColorValues
'warning-50': ColorValues
'warning-60': ColorValues
'warning-70': ColorValues
'warning-80': ColorValues
'warning-90': ColorValues
'warning-95': ColorValues
'success-5': ColorValues
'success-10': ColorValues
'success-20': ColorValues
'success-30': ColorValues
'success-40': ColorValues
'success-50': ColorValues
'success-60': ColorValues
'success-70': ColorValues
'success-80': ColorValues
'success-90': ColorValues
'success-95': ColorValues
'point-5': ColorValues
'point-10': ColorValues
'point-20': ColorValues
'point-30': ColorValues
'point-40': ColorValues
'point-50': ColorValues
'point-60': ColorValues
'point-70': ColorValues
'point-80': ColorValues
'point-90': ColorValues
'point-95': ColorValues
'graphic-10': ColorValues
'graphic-30': ColorValues
'graphic-50': ColorValues
'graphic-70': ColorValues
'graphic-90': ColorValues
}
class ColorValues {
light: string
high-contrast: string
}
colors ..> ColorValues : has
ColorValues ..> ColorThemeMode : uses
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lukasjhan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider generating the tailwind config from the color definitions to ensure consistency.
- The color palette in
packages/core/lib/colors/color.ts
is very comprehensive; ensure that it will be actively maintained and kept up-to-date.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Lukas.J.Han <[email protected]>
It closes #115
Summary by Sourcery
Updates the color system to use design tokens and introduces a color theme mode. This change replaces the previous color definitions with a new structure that supports light and high-contrast modes. It also removes the Color type and getTextColorClassname function.
Enhancements: