Skip to content

Conversation

Jeongyong-park
Copy link
Contributor

No description provided.

@lukasjhan lukasjhan linked an issue Dec 28, 2024 that may be closed by this pull request
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I got an error in CriticalAlert.stories.ts:4 when I start the storybook. Any idea why?

Internal server error: Failed to resolve import "@storybook/addon-viewport" from "stories/core/CriticalAlert.stories.ts". Does the file exist?

@lukasjhan
Copy link
Member

If viewport setup in parameters is removed, then it seems okay

@Jeongyong-park
Copy link
Contributor Author

If viewport setup in parameters is removed, then it seems okay

I removed that. review again pls

Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me, plz resolve the comment, then we could merge this.

@Jeongyong-park Jeongyong-park force-pushed the feat/critical-alert branch 2 times, most recently from 37d78de to 1547134 Compare January 8, 2025 04:58
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasjhan lukasjhan merged commit 01819c8 into KRDS-community:main Jan 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

긴급 공지 컴포넌트 제작

2 participants