Auto-size grid rows to ensure high-DPI visibility of checkboxes#4630
Merged
HebaruSan merged 3 commits intoMay 15, 2026
Conversation
78a86dc to
dfbfff2
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
mono-complete, runing CKAN throws an exception:Causees
dotnetcompiles for net481 on Windows, it generates a build that needs more dependencies than when Mono compiles for net481 on Linux, since we don't useSystem.ComponentModel.Compositionexplicitly anywhere in our own code.GUIMod.InstalledModbecomes stale when an installation failure causes the currentRegistryto be restored from its internal backup. A newInstalledModuleis deserialized and used by the registry, and meanwhile the correspondingGUIModretains a reference to the old object, so when it changes that object'sAutoInstalledproperty, the registry's object still has the old value.Changes
libmono-system-componentmodel-composition4.0-cilis added to the dependencies of the .deb package. In my testing, this makes CKAN work properly aftersudo apt install ckanon a fresh Ubuntu.Fixes FileNotFoundException: Could not load file or assembly 'System.ComponentModel.Composition on Linux #4600.
AutoSizeRowsModeproperty is set toDisplayedCellsExceptHeaders, which Jonno reported fixes the issue. TheDefaultCellStyle.Paddingproperty is set to try to keep the appearance rougly the same, since by default the auto-sizing packs the rows more tightly.Fixes [Bug]: Checkboxes disappear at higher windows scalings #4629.
GUIMod.InstalledModis retrieved from theRegistryon the fly as needed, so it will always return the currently correct object.Fixes CKAN still attempts to remove an auto-installed mod after explicitly trying to keep it after uninstall failure #4626.