Sync certs from newer location in RPM package#4642
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Mono has its own cert store, which ships empty, and CKAN doesn't work without certs. The
cert-syncutility can import certs from the sytem store into Mono's:Problem
The install of the RPM package fails on Fedora 44.
Cause
Fedora deleted
/etc/pki/tls/certs/ca-bundle.crtand/etc/pki/tls/cert.pem, and replaced them with/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem, see:Our RPM package's
%poststep tries to import the deleted files into Mono's cert store, which fails.Changes
Now we sync certs from
/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.peminstead, which is the replacement path according the above documentation. I confirmed that this file exists in thefedora:latestDocker image and thatcert-syncdoesn't fail to import it.(It did say
I already trust 146, your new list has 146, which suggests to me that the certs are already imported, but I don't trust that we can rely on that always being the case for all users on all RPM-based distros.)Fixes #4632.