Don't close 416 responses on dotnet#4646
Merged
HebaruSan merged 8 commits intoMay 26, 2026
Merged
Conversation
6bdaa65 to
92beb25
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
downloadingfolder of the cache contains a completed download for a module, trying to install it throws an exception on the net10 build:Causes
WebClientthat make it attempt to access the response when it did not in net481.Util.DarkModepreviously checked only that we were running on Windows and that the registry key was set. Unfortunately, the WinForms dark mode does not work on Windows 10 even if the registry key is set, soUtil.DarkModewas returning true despite the colors being light mode, which caused the colors of the file and folder icons to be inverted.ThemedTabControlturned off owner drawing for all net10 clients, even if dark mod was not activeChanges
Tests are included to exercise this.
Fixes [Bug]: Cannot access a disposed object 'System.Net.HttpWebResponse' #4572.
Krakens orIOExceptions orWebExceptions, to make such issues easier to investigateUtil.DarkModechecks for Windows 11, so the icons will not be inverted on Windows 10ThemedTabControluses owner drawing for light mode, so the tabs will look as they did in previous releases