Generate demos array in plugin #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KTibow
reviewed
Dec 28, 2025
KTibow
reviewed
Jan 1, 2026
Owner
|
So the way you did this (making it an array of promises but some insta resolved) is smart but some part of this - could even be the changed RESOLVED_PREFIX - seems to be glitchy in dev Screencast.From.2026-01-01.17-01-45.mp4 |
Contributor
Author
|
I believe this is inevitable as Vite won't inline the loop nor the await for the dev server, only for production builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generates an array of all the demos in the plugin to automate this step as well.