(fix) chess: remove extra step sneaking in at start of game - #1234
Merged
Conversation
dominoweir
changed the title
pim-at-stink
approved these changes
Jun 16, 2026
dominoweir
added a commit
that referenced
this pull request
Jun 16, 2026
This is pretty much a port of #1218 to this v2 visualizer as @pim-at-stink and I discussed yesterday. Will wait until after #1234 is merged to triple check and merge this. Background: We have a slightly different approach to forfeits in the latest batch of chess runs, and all episodes going forward- we now are overwriting the player's status to `DONE` when these forfeits from illegal moves happen. The fix here is to look for the specific case where the agent did try to make a submission (non null action status) but `action.submission === -1`. Changes: borrow heavily from the PR for the default visualizer, plus centralize forfeit labeling and reasons in forfeit.ts Before: <img width="1728" height="958" alt="977FAsvq4uquEGA" src="https://github.com/user-attachments/assets/b31b2aa7-16ee-4858-8fd9-e760c1a4abba" /> After: <img width="2560" height="1318" alt="5PEdwP4ck5nVvid" src="https://github.com/user-attachments/assets/8c769986-8015-4e0b-a15b-175e7905f2c0" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A byproduct of a recent update to chess episodes- the init steps of a game have their submission marked as null rather than -1, so we were getting an extra no-op step rendered in the UI:
Fixed by stronger typecheck, and a precursor to some forfeit display updates I'll send next. Also updated the replay to a more recent example, I'll do the same for forfeit in a bit once I find a good example in public data.
[general commentary, no-op] there's probably something to be done here about testing that the shape of the replay hasn't changed, but also, those tests wouldn't be helpful until the next time we try to change something that triggers the FE build checks... so not sure how helpful that would be ¯\_(ツ)_/¯ will have a think on that more as time allows next week