feat: nostalgic style - #695
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@pim-at-stink Can you review this before I merge please. FYI the CLA and kaggle-cicd warnings don't block us merging just now. |
|
@develra Can you drop in a screenshot here of what's failing the frontend kaggle-cicd job? I can't see the logs as I don't have permissions, but another PR with frontend changes passed ok so wondering if it's something really basic we can fix up easily. |
|
Sorry - annoying you can't see those. I'll disable these for a the non-master branch target in a moment and you can just use your action. I'll put investigating a better way to make those logs viewable onto my list. |
This is super helpful! Ahh, so it's my build stuff and https://nodejs.org/api/environment_variables.html#cli-options Not exactly sure why it's not happy with that? |
|
@develra I quickly tried moving loading Be good to know if it was because of the Was optimistic I'd got it there, but nope! |
|
@jim-at-stink - sorry pile of meetings today so slow to respond. I think you can ignore it for merging into this branch if you like - else I can look ina bit to see if I can get it passing. |
|
Different error this time. The only thing the build is doing is and
|
|
@develra No no, thank you, you've been great today! I see your build is happening on Node v19. Side question, sorry I should have asked before shouldn't I but is |
I think it's an accident - I'll figure out what base image we are using and update it to the latest node LTS |
Styling test using images taken from the art direction presentation.