Skip to content

feat: nostalgic style - #695

Merged
jim-at-stink merged 17 commits into
chess-v2/mainfrom
chess-v2/feat/nostalgic-style
Feb 9, 2026
Merged

feat: nostalgic style#695
jim-at-stink merged 17 commits into
chess-v2/mainfrom
chess-v2/feat/nostalgic-style

Conversation

@jim-at-stink

Copy link
Copy Markdown
Collaborator

Styling test using images taken from the art direction presentation.

Screenshot 2026-02-06 at 14 57 21

@google-cla

google-cla Bot commented Feb 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jim-at-stink
jim-at-stink marked this pull request as ready for review February 9, 2026 12:52
@jim-at-stink

Copy link
Copy Markdown
Collaborator Author

@pim-at-stink Can you review this before I merge please.

FYI the CLA and kaggle-cicd warnings don't block us merging just now.

@jim-at-stink

Copy link
Copy Markdown
Collaborator Author

@develra Can you drop in a screenshot here of what's failing the frontend kaggle-cicd job? I can't see the logs as I don't have permissions, but another PR with frontend changes passed ok so wondering if it's something really basic we can fix up easily.

@develra

develra commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Sorry - annoying you can't see those. I'll disable these for a the non-master branch target in a moment and you can just use your action. I'll put investigating a better way to make those logs viewable onto my list.

.../games/chess/visualizer/v2 build: node: bad option: --env-file-if-exists=.env
.../games/chess/visualizer/v2 build: Failed
/workspace/kaggle_environments/envs/open_spiel_env/games/chess/visualizer/v2:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kaggle-environments/open-spiel-chess-v2-visualizer@0.0.0 build: `tsc -b && vite build && node --env-file-if-exists=.env ./scripts/build.js --filter \*-visualizer`
 ```

@jim-at-stink

Copy link
Copy Markdown
Collaborator Author

.../games/chess/visualizer/v2 build: node: bad option: --env-file-if-exists=.env
.../games/chess/visualizer/v2 build: Failed
/workspace/kaggle_environments/envs/open_spiel_env/games/chess/visualizer/v2:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kaggle-environments/open-spiel-chess-v2-visualizer@0.0.0 build: tsc -b && vite build && node --env-file-if-exists=.env ./scripts/build.js --filter \*-visualizer
 ```

This is super helpful! Ahh, so it's my build stuff and --env-file-if-exists.

https://nodejs.org/api/environment_variables.html#cli-options

Not exactly sure why it's not happy with that?

@jim-at-stink

Copy link
Copy Markdown
Collaborator Author

@develra I quickly tried moving loading .env into build.js in a try/catch with the thought that it would be less likely to cause problems. But it failed again unfortunately.

Be good to know if it was because of the .env again, or something different this time.

Was optimistic I'd got it there, but nope!

@develra

develra commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

@jim-at-stink - sorry pile of meetings today so slow to respond.

I think you can ignore it for merging into this branch if you like - else I can look ina bit to see if I can get it passing.

@develra

develra commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Different error this time.

.../games/chess/visualizer/v2 build: file:///workspace/kaggle_environments/envs/open_spiel_env/games/chess/visualizer/v2/scripts/build.js:2
.../games/chess/visualizer/v2 build: import { loadEnvFile } from 'node:process';
.../games/chess/visualizer/v2 build:          ^^^^^^^^^^^
.../games/chess/visualizer/v2 build: SyntaxError: The requested module 'node:process' does not provide an export named 'loadEnvFile'
.../games/chess/visualizer/v2 build:     at ModuleJob._instantiate (node:internal/modules/esm/module_job:123:21)
.../games/chess/visualizer/v2 build:     at async ModuleJob.run (node:internal/modules/esm/module_job:189:5)
.../games/chess/visualizer/v2 build:     at async Promise.all (index 0)
.../games/chess/visualizer/v2 build:     at async ESMLoader.import (node:internal/modules/esm/loader:518:24)
.../games/chess/visualizer/v2 build:     at async loadESM (node:internal/process/esm_loader:102:5)
.../games/chess/visualizer/v2 build:     at async handleMainPromise (node:internal/modules/run_main:66:12)
.../games/chess/visualizer/v2 build: Node.js v19.0.0
.../games/chess/visualizer/v2 build: Failed

The only thing the build is doing is

npm install -g pnpm pnpm install node web/scripts/sync-version.js pnpm build-ci

and

npm install -g pnpm pnpm install # Install browsers matching the installed Playwright version pnpm exec playwright install chromium --with-deps pnpm test:e2e
  • maybe we can update the github action to mirror these in a reasonable way?

@jim-at-stink

Copy link
Copy Markdown
Collaborator Author

@develra No no, thank you, you've been great today!

I see your build is happening on Node v19. loadEnvFile() was only added in a later version of node. Got got it passing now. And all good to know for going forward.

Side question, sorry I should have asked before shouldn't I but is v19 what we should have been targeting all along? It's fairly old now (EOL too), so good for me to remember check things against if it's the case.

@develra

develra commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

@develra No no, thank you, you've been great today!

I see your build is happening on Node v19. loadEnvFile() was only added in a later version of node. Got got it passing now. And all good to know for going forward.

Side question, sorry I should have asked before shouldn't I but is v19 what we should have been targeting all along? It's fairly old now (EOL too), so good for me to remember check things against if it's the case.

I think it's an accident - I'll figure out what base image we are using and update it to the latest node LTS

@jim-at-stink
jim-at-stink merged commit 342d694 into chess-v2/main Feb 9, 2026
3 of 4 checks passed
@jim-at-stink
jim-at-stink deleted the chess-v2/feat/nostalgic-style branch February 9, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants