Skip to content

feat: split to components - #703

Merged
jim-at-stink merged 3 commits into
chess-v2/mainfrom
chess-v2/feat/split-to-components
Feb 11, 2026
Merged

feat: split to components#703
jim-at-stink merged 3 commits into
chess-v2/mainfrom
chess-v2/feat/split-to-components

Conversation

@jim-at-stink

Copy link
Copy Markdown
Collaborator

Splitting the single big chunk of example and test code in App.tsx into a set of components in components and state.

@google-cla

google-cla Bot commented Feb 11, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jim-at-stink
jim-at-stink marked this pull request as ready for review February 11, 2026 10:05
@jim-at-stink
jim-at-stink force-pushed the chess-v2/feat/split-to-components branch from adbdb5a to 056af90 Compare February 11, 2026 11:17
@jim-at-stink

jim-at-stink commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator Author

@adrian-at-stink I've changed the react component definitions to use the function keyword now instead of arrow functions. Component file names are CamelCase.

Tried useMemo as suggested but it didn't play nice with the replay visualizer factory, so left as useEffect for now. Will review all that again later if that's ok.

Can you take another look, and submit a review, when you get a mo'.

EDIT: Hold that thought. Lint error I'd missed. Will fix that first. Back on again, please do check now, it was an out of date test that was showing the error. Thanks!

@adrian-at-stink adrian-at-stink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jim-at-stink - looks good to me

@jim-at-stink
jim-at-stink merged commit 735b965 into chess-v2/main Feb 11, 2026
1 of 2 checks passed
@jim-at-stink
jim-at-stink deleted the chess-v2/feat/split-to-components branch February 11, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants