feat: side panel controls - #729
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@develra I've switched things over here and in |
develra
left a comment
There was a problem hiding this comment.
Looks fine to me as long as it works - let me know if you need adjustments to ReplayAdapter / createReplayVisualizer for anything.
| @@ -1,3 +1,4 @@ | |||
| /* | |||
| :root { | |||
There was a problem hiding this comment.
Is this all commented out now? If so maybe remove if you don't think you'll need it in the future.
Switching over to using the
GameRendererReact component instead of a legacy render function, to match the approach and some naming used in thego-v2visualizer.Initially fix issues where the game steps weren't updating due to some stuff with the resize observer in the handling of the legacy approach, this has the added benefit of correctly wrapping the React renderer in the various playback controls so they now show correctly when in
side-panelmode.