Skip to content

feat: side panel controls - #729

Merged
jim-at-stink merged 5 commits into
chess-v2/mainfrom
chess-v2/feat/side-panel-controls
Feb 27, 2026
Merged

feat: side panel controls#729
jim-at-stink merged 5 commits into
chess-v2/mainfrom
chess-v2/feat/side-panel-controls

Conversation

@jim-at-stink

@jim-at-stink jim-at-stink commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Switching over to using the GameRenderer React component instead of a legacy render function, to match the approach and some naming used in the go-v2 visualizer.

Initially fix issues where the game steps weren't updating due to some stuff with the resize observer in the handling of the legacy approach, this has the added benefit of correctly wrapping the React renderer in the various playback controls so they now show correctly when in side-panel mode.

Screenshot 2026-02-26 at 10 51 46 Screenshot 2026-02-26 at 10 51 31

@google-cla

google-cla Bot commented Feb 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jim-at-stink
jim-at-stink requested a review from develra February 26, 2026 10:59
@jim-at-stink

Copy link
Copy Markdown
Collaborator Author

@develra I've switched things over here and in go-v2 to pass in a React component to the ReplayAdapter instead of the legacy function, can you take a quick look and let me know if thist is how you'd anticipated this React component approach to be done? Thanks!

@develra develra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as long as it works - let me know if you need adjustments to ReplayAdapter / createReplayVisualizer for anything.

@@ -1,3 +1,4 @@
/*
:root {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all commented out now? If so maybe remove if you don't think you'll need it in the future.

@jim-at-stink
jim-at-stink marked this pull request as ready for review February 27, 2026 14:13
@jim-at-stink
jim-at-stink merged commit 96059e8 into chess-v2/main Feb 27, 2026
1 of 2 checks passed
@jim-at-stink
jim-at-stink deleted the chess-v2/feat/side-panel-controls branch February 27, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants