fix: game over winner - #851
Merged
Merged
Conversation
jim-at-stink
marked this pull request as ready for review
March 26, 2026 10:42
pim-at-stink
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zoonou spotted that the winner was incorrectly displayed on the
GameOverscreen.This was a bug from a change I made to add the extra
GameOverstep in at the end after the player moves, I was settingplayersto an empty default for this step, but theoptionsare being used in this component to select the winner directly from the content of the replay log, specifically therewardvalue on each player.This PR fixes up this issue by setting the
playersto theplayerson the last real move made by the LLM.