feat(go): add mute button - #853
Merged
Merged
Conversation
pim-at-stink
commented
Mar 26, 2026
pim-at-stink
commented
Collaborator
Collaborator
|
I think audio needs to be turned off by default, as sounds won't play before the user clicks in the (Unless Kaggle can delegate permission to play audio from the parent page to the iframe?) But Duncs did ask for it to be the way you've done it : ) So I've asked Kate how it should function now on the issue ticket. And let's merge it in so I can deploy a version for the gang to review when they're chatting about it. |
jim-at-stink
approved these changes
Mar 26, 2026
jim-at-stink
left a comment
jim-at-stink
left a comment
Collaborator
There was a problem hiding this comment.
Let's merge so Duncs can review!
jim-at-stink
pushed a commit
that referenced
this pull request
Mar 31, 2026
<img width="137" height="230" alt="Screenshot 2026-03-26 at 11 04 35" src="https://github.com/user-attachments/assets/43d5e5b1-6d00-4243-9930-dd9ca1a1d38d" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.