feat: score panel by media width - #898
Closed
jim-at-stink wants to merge 2 commits into
Closed
Conversation
jim-at-stink
force-pushed
the
go-v2/feat/score-panel-by-media-width
branch
from
March 31, 2026 09:19
8d9825f to
c0aef79
Compare
Collaborator
Author
|
It does cause this issue with the 
|
jim-at-stink
force-pushed
the
go-v2/main
branch
from
March 31, 2026 15:14
52b4baa to
74dcdeb
Compare
jim-at-stink
force-pushed
the
go-v2/feat/score-panel-by-media-width
branch
from
March 31, 2026 16:57
c0aef79 to
1e23e9e
Compare
jim-at-stink
force-pushed
the
go-v2/feat/score-panel-by-media-width
branch
from
March 31, 2026 17:01
1e23e9e to
74dcdeb
Compare
Collaborator
Collaborator
Author
|
@pim-at-stink made a fix which was simpler and just used a different width breakpoint. So I'm closing this PR and deleting the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sizing of elements of the
ScorePanelis adjusted depending on theplayableAreacontainer size.This means that even on large screen size, when the LLM logs are at the right of the visualizer we get a small container size, so the pots and text are shrunk down in a way that's really intended for on small screens.
This leads to the sizing of these elements bouncing back and forward as the log viewer moves its position.
Before this change:
Using the
mediaquery instead ofcontainerto only reduce the size ofScorePanelelements if theplayableAreais small AND the LLM log are below the visualizer.@pim-at-stink Does this make sense as an approach, or am I breaking things here?