fix(go): announce rive popover copy for screen readers - #908
Merged
Conversation
dominoweir
reviewed
Apr 7, 2026
Comment on lines
+85
to
+87
| <span aria-live="assertive" className="visually-hidden"> | ||
| {isVisible ? hero?.text : ''} | ||
| </span> |
Contributor
There was a problem hiding this comment.
@pim-at-stink sorry to barge in but I randomly spotted this PR and wanted to ask- would it be helpful to you if we had a more "global" aria live region that you could just send a message to when isVisible changes? I can definitely work to set that up if so.
Collaborator
Author
There was a problem hiding this comment.
Yes! super helpful thank you - I saw the PR. We are going to merge this for now, and we will do a follow-up PR soon to make use of the new system
jim-at-stink
approved these changes
Apr 8, 2026
dominoweir
added a commit
that referenced
this pull request
Apr 8, 2026
Currently announces just the step description and thoughts if present, but this is wired up such that individual visualizers can push messages to the region too (adding @pim-at-stink since this might be a smoother experience than a second live region in #908 and I want to make sure what I'm doing is helpful)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.