Skip to content

Conversation

@ju-Skinner
Copy link
Contributor

@ju-Skinner ju-Skinner commented Oct 16, 2024

Description

Updates the style for both :focus-visible and :hover states.

See ticket for more details as to why this is on hold

Fixes #(issue)
DSS-1053

Type of change

  • Style (visual changes only)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other: Storybook

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@ju-Skinner ju-Skinner self-assigned this Oct 16, 2024
@github-actions github-actions bot added the package: core Changes have been made to the Core package label Oct 16, 2024
@netlify
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 487f05a
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/670fd40393f80200084a59f9
😎 Deploy Preview https://deploy-preview-276--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner added the DO NOT MERGE Hold off on merging this label Oct 18, 2024
@ju-Skinner ju-Skinner changed the title style(pds-link): update focus-visible and hover states based on figma design [DNM] style(pds-link): update focus-visible and hover states based on figma design Oct 18, 2024
@ju-Skinner ju-Skinner force-pushed the main branch 4 times, most recently from bab7cd1 to 05e3572 Compare February 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Hold off on merging this package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants