style: updates Table styling to match Figma design #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package: core
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
QuintonJason
requested changes
May 2, 2025
Contributor
QuintonJason
left a comment
QuintonJason
left a comment
There was a problem hiding this comment.
Nice work! Left some comments regarding logical properties and noticed
It doesn't show all the time, seems to based on screen width
| // because it is in the ShadowDom | ||
| &::part(checkbox-cell) { | ||
| background-color: var(--pine-color-background-container); | ||
| border-top-left-radius: var(--pine-dimension-125); |
Contributor
There was a problem hiding this comment.
Update to use logical properties
| } | ||
|
|
||
| ::slotted(pds-table-cell:first-child) { | ||
| border-bottom-left-radius: var(--pine-dimension-125); |
Contributor
There was a problem hiding this comment.
Update to use logical properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Pine Table styles to match Figma component.
DSS-1341
Type of change
Before:
After:
How Has This Been Tested?
Test Configuration:
Checklist:
If not applicable, leave options unchecked.