Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Success message #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jahnvigupta
Copy link
Collaborator

No description provided.

@kpbot kpbot added the size: S label Jun 28, 2019
@vsvipul vsvipul requested a review from Varunvaruns9 June 28, 2019 20:58
@kpbot kpbot added size: XL and removed size: S labels Jun 29, 2019
Copy link
Member

@Varunvaruns9 Varunvaruns9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the working but the styling still looks very ugly. @jahnvigupta can you please fix that?

Copy link
Member

@Varunvaruns9 Varunvaruns9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.



<style>
img {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in styles.css.

<div class="messages">
<font align = "center">
{% if messages %}
<img src = "{% static "images/success.gif" %}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is quite large and doesn't disappear automatically. Can you hide it after some time using jquery or just js?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use a smaller image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants