feat: implement quality gates with CI/CD pipeline and pre-commit hooks#5
Merged
KannuSingh merged 10 commits intomasterfrom Aug 10, 2025
Merged
feat: implement quality gates with CI/CD pipeline and pre-commit hooks#5KannuSingh merged 10 commits intomasterfrom
KannuSingh merged 10 commits intomasterfrom
Conversation
Owner
KannuSingh
commented
Aug 10, 2025
KannuSingh
commented
- Add GitHub Actions workflow for automated typecheck, lint, build, and format checks
- Configure pre-commit hooks with husky and lint-staged for local quality validation
- Add husky and lint-staged dependencies for git hooks management
- Set up automated code formatting and linting before commits
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Add GitHub Actions workflow for automated typecheck, lint, build, and format checks - Configure pre-commit hooks with husky and lint-staged for local quality validation - Add husky and lint-staged dependencies for git hooks management - Set up automated code formatting and linting before commits
- Reorder CI steps to build packages first, then run typecheck - Fixes TypeScript compilation errors due to missing declaration files - Ensures workspace dependencies are built before type checking
- Extract pnpm version from package.json packageManager field for consistency - Optimize pre-commit hooks to use incremental TypeScript checking - Replace slow workspace-wide typecheck with faster tsc --noEmit --incremental - Ensures CI uses same pnpm version as specified in project configuration
- Improve TypeScript checking in pre-commit hooks to check entire project - Update Node.js version to '20.x' for more specific version control - Add vercel.json to docs app to fix deployment output directory issue - Configure correct build output directory as 'dist' for Vocs framework
- Update Node.js version to '20.x' for more consistent builds - Improve TypeScript checking in pre-commit hooks to validate entire project - Separate ESLint fixes from TypeScript checking for better performance - Ensure cross-file type dependencies are properly validated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Remove duplicate '*.{ts,tsx}' pattern in .lintstagedrc.json
- Remove inefficient TypeScript checking from pre-commit hooks
- Keep fast formatting and linting checks for pre-commit
- TypeScript validation handled comprehensively in CI pipeline
KannuSingh
force-pushed
the
feat/implement-quality-gates
branch
from
95cd670 to
693237e
Compare
…atting - Update CI workflow to auto-format code before checks - Reorder CI steps: format -> build -> typecheck -> lint -> format-check - Apply Prettier formatting across all files for consistency - Include manual improvements and fixes to codebase - Ensure CI is more developer-friendly by auto-fixing formatting issues
- Remove auto-format step from CI to avoid hiding formatting issues - Keep format check to enforce standards on committed code - Rely on pre-commit hooks for local auto-formatting - Ensure CI validates actual committed code, not auto-modified version - Maintain clear separation: local hooks fix, CI validates
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive quality gates for the prepaid-gas package repository by adding CI/CD automation and pre-commit hooks to ensure code quality and consistency.
- Add GitHub Actions CI workflow with automated typecheck, lint, build, and format checks
- Configure pre-commit hooks using husky and lint-staged for local code quality validation
- Add formatting automation and dependency management for git hooks
Reviewed Changes
Copilot reviewed 44 out of 60 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | GitHub Actions CI workflow for quality checks |
| .lintstagedrc.json | Lint-staged configuration for pre-commit hooks |
| package.json | Add husky, lint-staged dependencies and prepare script |
| Multiple files | Code formatting changes applied by prettier |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
- Remove complex pnpm version extraction script - Use pnpm/action-setup@v4's built-in packageManager detection - Addresses Copilot feedback about robustness and error handling - Simplifies CI workflow while maintaining version consistency - Official action handles malformed JSON and missing files gracefully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.