Use Material 3 Expressive loading indicators#123
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 627be8d50c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| final indicator = contained | ||
| ? LoadingIndicator.contained( | ||
| activeIndicatorColor: activeColor, |
There was a problem hiding this comment.
When the contained variant is used without an explicit color (as it is from M3ERefreshIndicator), this always passes colorScheme.primary as activeIndicatorColor, overriding the contained indicator’s intended/default contrast color for a primaryContainer background. In themes where primary is close to primaryContainer, the pull-to-refresh shape becomes hard to see; let the contained case use onPrimaryContainer or leave the package default when color is null.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 496a7b041c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| child: widget.child, | ||
| ), | ||
| Positioned( | ||
| top: top, |
There was a problem hiding this comment.
In contexts with a reversed vertical scrollable (checked lib/features/settings/log_viewer_page.dart, where this wrapper now contains ListView.builder(reverse: true)), RefreshIndicator.noSpinner arms from the bottom edge, but this custom overlay is always positioned from the top. Pull-to-refresh in the log viewer therefore shows the M3E indicator at the opposite edge from the user's gesture; derive the overlay edge from the scroll notification/axis direction or handle reversed lists before replacing all RefreshIndicator usages.
Useful? React with 👍 / 👎.
1 participant
No description provided.