feat(DataMapper): Members of collection choice inherit collection sem…#3215
feat(DataMapper): Members of collection choice inherit collection sem…#3215mmelko wants to merge 1 commit into
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3215 +/- ##
=======================================
Coverage 92.25% 92.26%
=======================================
Files 636 636
Lines 24633 24641 +8
Branches 5843 5848 +5
=======================================
+ Hits 22726 22734 +8
Misses 1797 1797
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmelko
force-pushed
the
fix/3167-collection-choice-members
branch
from
5403ad5 to
f9941ba
Compare
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
…antics (KaotoIO#3167) - Add isFieldInsideCollectionChoiceWrapper() helper to check if field is inside collection choice - Update DocumentService.isCollectionField() to consider collection choice inheritance - Update VisualizationUtilService.isCollectionField() documentation - Add comprehensive tests for collection choice inheritance - Add tests using TestDocument.xsd CollectionChoiceElement - Verify non-collection choice members are unaffected (no regression) Fixes KaotoIO#3167
mmelko
force-pushed
the
fix/3167-collection-choice-members
branch
from
f9941ba to
47504d3
Compare
|
igarashitm
left a comment
igarashitm
left a comment
There was a problem hiding this comment.
Just one test stub organization, otherwise LGTM 👍
| it('should identify members of collection choice as collection fields', async () => { | ||
| const mockApi = { | ||
| getResourceContent: jest.fn().mockResolvedValue(` | ||
| <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" targetNamespace="test" xmlns:ns0="test"> |
There was a problem hiding this comment.
Can you use existing TestDocument.xsd or create a new stub XSD file in src/stubs/datamapper/xml so that it could be used to reproduce it manually? It would be better if one XSD file can serve all test cases added here.
2 participants
…antics (#3167)
Fixes #3167