Repository navigation
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 174 files, which is 74 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters: 14
📒 Files selected for processing: 174
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PVinaches
force-pushed
the
feat/bring-forms-copy-2
branch
from
October 23, 2026 14:47
2e29281 to
fff6fd2
Compare
PVinaches
force-pushed
the
feat/bring-forms-copy-2
branch
from
October 23, 2026 15:16
fff6fd2 to
755896e
Compare
PVinaches
marked this pull request as ready for review
October 23, 2026 15:17
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
@kaoto/formslibrary (previously inKaotoIO/forms) into the monorepo aspackages/forms. It also migrates its UI from PatternFly to Carbon. The library renders JSON-schema forms for Apache Camel component schemas (KaotoForm, field components,Typeahead,KeyValue, validation, and utils).Part of #3939
What changed
packages/formswith its sources, tests, snapshots, stubs and testing helpers (@kaoto/forms/testing,@kaoto/forms/testing/page-object).package.json,tsconfig*.json,vite.config.mjs,vitest.config.mts,vitest-setup.ts,index.htmland a README.@carbon/react,@carbon/ibm-products,@carbon/icons-react,@carbon/styles). They are declared as peer dependencies, and no@patternflyimports remain inpackages/forms/src.package.json: workspaces are now["packages/*", "!packages/forms"].Notes for reviewers
packages/formsis excluded from the root Yarn workspaces for now, so the package isn't linked or built with the rest of the monorepo. Wiring it into@kaoto/kaotois left for a follow-up PR (WIP).Type of Change
How Has This Been Tested?
packages/forms/src/**/*.test.tsx, run with Vitest:yarn workspace @kaoto/forms test.yarn workspace @kaoto/forms typecheckandyarn workspace @kaoto/forms build.yarn workspace @kaoto/forms lint.Checklist