Feat/store history undo redo #3038
+305
−24
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import { createStore, batch } from './store'; | ||
|
|
||
| describe('createStore history option', () => { | ||
| it('undo()/redo() round-trip a plain setState', () => { | ||
| const store = createStore(() => ({ count: 0 }), { history: { limit: 50 } }); | ||
| store.setState({ count: 1 }); | ||
| store.setState({ count: 2 }); | ||
|
|
||
| store.undo(); | ||
| expect(store.getState().count).toBe(1); | ||
| store.undo(); | ||
| expect(store.getState().count).toBe(0); | ||
| store.redo(); | ||
| expect(store.getState().count).toBe(1); | ||
| }); | ||
|
|
||
| it('batch() collapses to exactly one history entry', () => { | ||
| const store = createStore((set) => ({ | ||
| count: 0, | ||
| increment: () => set((s) => ({ count: s.count + 1 })), | ||
| }), { history: { limit: 50 } }); | ||
|
|
||
| batch(() => { | ||
| store.getState().increment(); | ||
| store.getState().increment(); | ||
| store.getState().increment(); | ||
| }); | ||
|
|
||
| expect(store.getHistory().past.length).toBe(1); | ||
|
Check failure on line 30 in packages/store/src/history-option.test.ts
|
||
| store.undo(); | ||
| expect(store.getState().count).toBe(0); | ||
| }); | ||
|
|
||
| it('undo() throws when history option is not set', () => { | ||
| const store = createStore(() => ({ count: 0 })); | ||
| expect(() => store.undo()).toThrow(/requires the "history" option/); | ||
| }); | ||
|
|
||
| it('undo() throws when called inside batch()', () => { | ||
| const store = createStore(() => ({ count: 0 }), { history: {} }); | ||
| expect(() => { | ||
| batch(() => { | ||
| store.undo(); | ||
| }); | ||
| }).toThrow(/cannot be called inside batch/); | ||
| }); | ||
|
|
||
| it('coalesceMs merges updates that occur within the window (timestamp-based, not timer-based)', () => { | ||
| vi.useFakeTimers(); | ||
| vi.setSystemTime(0); | ||
| const store = createStore(() => ({ n: 0 }), { history: { coalesceMs: 300 } }); | ||
|
|
||
| store.setState({ n: 1 }); | ||
| vi.setSystemTime(100); // still inside the 300ms window | ||
| store.setState({ n: 2 }); | ||
|
|
||
| expect(store.getHistory().past.length).toBe(1); | ||
|
|
||
| vi.setSystemTime(500); // window has elapsed | ||
| store.setState({ n: 3 }); | ||
| expect(store.getHistory().past.length).toBe(2); | ||
|
|
||
| vi.useRealTimers(); | ||
| }); | ||
|
|
||
| it('limit caps the past stack', () => { | ||
| const store = createStore(() => ({ n: 0 }), { history: { limit: 3 } }); | ||
| for (let i = 1; i <= 5; i++) store.setState({ n: i }); | ||
| expect(store.getHistory().past.length).toBe(3); | ||
| }); | ||
|
|
||
| it('resetHistory() clears both stacks without touching state', () => { | ||
| const store = createStore(() => ({ n: 0 }), { history: {} }); | ||
| store.setState({ n: 1 }); | ||
| store.resetHistory(); | ||
| expect(store.getHistory()).toEqual({ past: [], future: [] }); | ||
| expect(store.getState().n).toBe(1); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,15 +1,15 @@ | ||||||||||||||||||||
| import type { Store } from './store.js'; | ||||||||||||||||||||
| export interface StoreSnapshot<T> { | ||||||||||||||||||||
| id: number; | ||||||||||||||||||||
| label?: string; | ||||||||||||||||||||
| state: T; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| export interface SnapshotHistoryOptions { | ||||||||||||||||||||
| limit?: number; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| export interface StoreSnapshotHistory<T extends object> { | ||||||||||||||||||||
| capture(label?: string): StoreSnapshot<T>; | ||||||||||||||||||||
| restore(id: number): StoreSnapshot<T>; | ||||||||||||||||||||
|
|
@@ -18,7 +18,40 @@ export interface StoreSnapshotHistory<T extends object> { | |||||||||||||||||||
| list(): StoreSnapshot<T>[]; | ||||||||||||||||||||
| clear(): void; | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // Deep-clone while stripping function values at every level — action | ||||||||||||||||||||
| // methods (set()-bound closures) live directly on store state and are not | ||||||||||||||||||||
| // structured-cloneable. This mirrors store.ts's own safeDeepClone, which | ||||||||||||||||||||
| // exists for the same reason. | ||||||||||||||||||||
| function cloneState<T>(state: T): T { | ||||||||||||||||||||
| const strip = (value: unknown): unknown => { | ||||||||||||||||||||
| if (value === null || typeof value !== 'object') return value; | ||||||||||||||||||||
| if (value instanceof Date || value instanceof RegExp) return value; | ||||||||||||||||||||
| if (Array.isArray(value)) return value.map(strip); | ||||||||||||||||||||
| if (value instanceof Map) { | ||||||||||||||||||||
| const m = new Map(); | ||||||||||||||||||||
| for (const [k, v] of value) m.set(k, strip(v)); | ||||||||||||||||||||
| return m; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| if (value instanceof Set) { | ||||||||||||||||||||
| const s = new Set(); | ||||||||||||||||||||
| for (const v of value) s.add(strip(v)); | ||||||||||||||||||||
| return s; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| const out: Record<string, unknown> = {}; | ||||||||||||||||||||
| for (const [k, v] of Object.entries(value as Record<string, unknown>)) { | ||||||||||||||||||||
| if (typeof v === 'function') continue; | ||||||||||||||||||||
| out[k] = strip(v); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Comment on lines
+27
to
+45
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift Strip functions before handling container types. Functions in arrays, Sets, Map values, or Map keys currently reach 🤖 Prompt for AI Agents |
||||||||||||||||||||
| return out; | ||||||||||||||||||||
| }; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| const stripped = strip(state); | ||||||||||||||||||||
| return typeof structuredClone === 'function' | ||||||||||||||||||||
| ? structuredClone(stripped as T) | ||||||||||||||||||||
| : (JSON.parse(JSON.stringify(stripped)) as T); | ||||||||||||||||||||
|
Comment on lines
+26
to
+52
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
ast-grep run --lang ts --pattern '$EXPR as $TYPE' packages/store/src/snapshot-history.tsRepository: Karanjot786/TermUI Length of output: 663 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "File size and relevant contents:"
wc -l packages/store/src/snapshot-history.ts
cat -n packages/store/src/snapshot-history.ts
echo
echo "Type assertion occurrences with inline comments:"
python3 - <<'PY'
from pathlib import Path
p=Path("packages/store/src/snapshot-history.ts")
text=p.read_text()
for i,line in enumerate(text.splitlines(),1):
if " as " in line:
print(f"{i}: {line}")
PYRepository: Karanjot786/TermUI Length of output: 5473 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Store.ts outline:"
ast-grep outline packages/store/src/store.ts --view expanded || true
echo
echo "Relevant Store<T> contents:"
wc -l packages/store/src/store.ts
sed -n '1,180p' packages/store/src/store.ts | cat -n
echo
echo "Behavioral probe for cloneState stripping and clone behavior:"
node - <<'JS'
function probeClone(fn) {
const original = {
label: 'x',
value: 1,
action: () => 'action',
nested: { fnField: () => 'nested', list: [{ fnField: () => 'nested item' }, 1], map: new Map([['fnField', () => 'map fn']]), set: new Set([() => 'set fn', 1]) },
};
const stripped = fn(original.state || original ?? original);
return {
originalKeys: Object.keys(original),
returnedKeys: Object.keys(stripped),
topActionAbsent: typeof stripped.action === 'function' ? 'present' : 'absent',
nestedFnAbsent: typeof stripped.nested?.fnField === 'function' ? 'present' : 'absent',
listFnCount: (stripped.nested?.list ?? []).filter(i => typeof i === 'function').length,
mapEntries: [...(stripped.nested?.map ?? [])].filter(([k, v]) => typeof k === 'string' && k.endsWith('Field')).length,
};
}
const hasStructuredClone = typeof globalThis.structuredClone === 'function';
console.log(JSON.stringify({
hasStructuredClone,
stripJson: probeClone(s => (s && typeof s === 'object' && !Array.isArray(s) && !(s instanceof Date || s instanceof RegExp || s instanceof Map || s instanceof Set))
? JSON.parse(JSON.stringify(s)) : s),
stripObjectEntries: probeClone(s => (() => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return out;
})()),
cloneResult: hasStructuredClone ? probeClone((s) => globalThis.structuredClone(s)) : null,
}));
JS
echo
echo "Check Store<T> action typing/usages:"
rg -n "Store<[^>]+>.*:|Store\\(" packages --glob '*.ts' --glob '*.tsx' | head -120Repository: Karanjot786/TermUI Length of output: 9639 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Relevant Store<T> contents:"
sed -n '188,820p' packages/store/src/store.ts | cat -n
echo
echo "Behavioral probe for cloneState stripping and clone behavior:"
node - <<'JS'
function probeClone(fn) {
const original = {
label: 'x',
value: 1,
action: () => 'action',
nested: { fnField: () => 'nested', list: [{ fnField: () => 'nested item' }, 1], map: new Map([['fnField', () => 'map fn']]), set: new Set([() => 'set fn', 1]) },
};
const stripped = fn(original);
return {
originalKeys: Object.keys(original),
returnedKeys: Object.keys(stripped),
topActionAbsent: typeof stripped.action === 'function' ? 'present' : 'absent',
nestedFnAbsent: typeof stripped.nested?.fnField === 'function' ? 'present' : 'absent',
listFnCount: (stripped.nested?.list ?? []).filter(i => typeof i === 'function').length,
mapEntries: [...(stripped.nested?.map ?? [])].filter(([k, v]) => typeof k === 'string' && k.endsWith('Field')).length,
};
}
const hasStructuredClone = typeof globalThis.structuredClone === 'function';
console.log(JSON.stringify({
hasStructuredClone,
stripJson: probeClone(s => ((s && typeof s === 'object' && !Array.isArray(s) && !(s instanceof Date || s instanceof RegExp || s instanceof Map || s instanceof Set))
? JSON.parse(JSON.stringify(s)) : s)),
stripObjectEntries: probeClone(s => (() => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return out;
})()),
cloneResult: hasStructuredClone ? probeClone((s) => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return globalThis.structuredClone(out);
}) : null
}, null, 2));
JS
echo
echo "Check Store<T> action factory examples/usages:"
rg -n "createStore\\([^\\n]+=>|set\\([^\\n]+=>\\s*\\({|increment:|reset:|setState\\(" packages --glob '*.ts' --glob '*.tsx' | head -200Repository: Karanjot786/TermUI Length of output: 27949 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Behavioral probe for cloneState stripping and clone behavior:"
node - <<'JS'
function probeClone(fn, input) {
const stripped = fn(input);
const arr = stripped?.nested?.list ?? [];
const map = stripped?.nested?.map ?? new Map();
const mapEntries = [...map.entries()].filter(([k, v]) => typeof k === 'string' && k.endsWith('Field'));
return {
originalKeys: Object.keys(input),
returnedKeys: Object.keys(stripped),
topActionAbsent: typeof stripped.action === 'function' ? 'present' : 'absent',
nestedFnAbsent: typeof stripped.nested?.fnField === 'function' ? 'present' : 'absent',
listFnCount: arr.reduce((n, i) => n + (typeof i === 'function' ? 1 : 0), 0),
mapValuesWithFnKey: mapEntries.filter(([, v]) => typeof v === 'function').length,
};
}
const hasStructuredClone = typeof globalThis.structuredClone === 'function';
const input = {
label: 'x',
value: 1,
action: () => 'action',
nested: {
fnField: () => 'nested',
list: [{ fnField: () => 'nested item' }, 1],
map: new Map([['fnField', () => 'map fn']]),
set: new Set([() => 'set fn', 1]),
},
};
console.log(JSON.stringify({
hasStructuredClone,
stripJson: probeClone(s => ((s && typeof s === 'object' && !Array.isArray(s) && !(s instanceof Date || s instanceof RegExp || s instanceof Map || s instanceof Set))
? JSON.parse(JSON.stringify(s)) : s), input),
stripObjectEntries: probeClone(s => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return out;
}, input),
cloneResult: hasStructuredClone ? probeClone((s) => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return globalThis.structuredClone(out);
}, input) : null
}, null, 2));
console.log("JSON.stringify preserves custom Date RegExp:");
const obj = { date: new Date("2000-01-01T12:34:56Z"), re: /abc/gi, func: () => {} };
console.log(JSON.stringify(JSON.parse(JSON.stringify(obj))));
JSRepository: Karanjot786/TermUI Length of output: 943 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Behavioral probe for cloneState stripping and clone behavior:"
node - <<'JS'
function probeClone(fn, input) {
const stripped = fn(input);
const arr = stripped && stripped.nested && stripped.nested.list ? stripped.nested.list : [];
const map = stripped && stripped.nested && stripped.nested.map ? stripped.nested.map : new Map();
const mapEntries = Array.from(map.entries()).filter(([k, v]) => typeof k === 'string' && k.endsWith('Field'));
return {
originalKeys: Object.keys(input),
returnedKeys: stripped ? Object.keys(stripped) : [],
topActionAbsent: typeof (stripped && stripped.action) === 'function' ? 'present' : 'absent',
nestedFnAbsent: typeof (stripped && stripped.nested && stripped.nested.fnField) === 'function' ? 'present' : 'absent',
listFnCount: arr.reduce((n, i) => n + (typeof i === 'function' ? 1 : 0), 0),
mapValuesWithFnKey: mapEntries.filter(([, v]) => typeof v === 'function').length,
};
}
const hasStructuredClone = typeof globalThis.structuredClone === 'function';
const input = {
label: 'x',
value: 1,
action: () => 'action',
nested: {
fnField: () => 'nested',
list: [{ fnField: () => 'nested item' }, 1],
map: new Map([['fnField', () => 'map fn']]),
set: new Set([() => 'set fn', 1]),
},
};
console.log(JSON.stringify({
hasStructuredClone,
stripJson: probeClone(s => ((s && typeof s === 'object' && !Array.isArray(s) && !(s instanceof Date || s instanceof RegExp || s instanceof Map || s instanceof Set))
? JSON.parse(JSON.stringify(s)) : s), input),
strictObjectEntries: probeClone(s => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return out;
}, input),
cloneResult: hasStructuredClone ? probeClone((s) => {
const out = {};
for (const [k, v] of Object.entries(s)) {
if (typeof v === 'function') continue;
out[k] = v;
}
return globalThis.structuredClone(out);
}, input) : null
}, null, 2));
console.log("JSON.stringify preserves custom Date RegExp:");
const obj = { date: new Date("2000-01-01T12:34:56Z"), re: /abc/gi, func: () => {} };
console.log(JSON.stringify(JSON.parse(JSON.stringify(obj))));
JSRepository: Karanjot786/TermUI Length of output: 921 🏁 Script executed: #!/bin/bash
set -euo pipefail
node - <<'JS'
console.log(process.version, typeof globalThis.structuredClone);
const input = {
action: function action() { return 'action'; },
nested: {
fnField: function fnField() { return 'nested'; },
list: [function nestedFn() { return 'nested item'; }, 1],
set: new Set([function setFn() {}, 1]),
},
};
console.log("Object.keys(input):", Object.keys(input));
console.log("JSON.stringify(JSON.parse(input)):");
console.log(JSON.stringify(JSON.parse(JSON.stringify(input))));
const stripped = {};
for (const [k, v] of Object.entries(input)) {
if (typeof v === 'function') continue;
stripped[k] = v;
}
console.log("Object.keys(stripped):", Object.keys(stripped));
const clonedMap = new Map();
clonedMap.set('fnField', function mapFn() {});
console.log("cloneWithMapObjectKeys:", Object.keys(clonedMap));
console.log("cloneWithMapMapEntries:", [...clonedMap.entries()]);
console.log("delete function cloneWithMap:");
const clonedDeleteMap = new Map();
clonedDeleteMap.set('fnField', function mapFn() {});
setDeleteMap(clonedDeleteMap, 'fnField');
console.log([...clonedDeleteMap.entries()]);
JSRepository: Karanjot786/TermUI Length of output: 1050 Return non-action state from snapshot history.
🤖 Prompt for AI AgentsSource: Coding guidelines |
||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| export function createSnapshotHistory<T extends object>( | ||||||||||||||||||||
| store: Store<T>, | ||||||||||||||||||||
| options: SnapshotHistoryOptions = {}, | ||||||||||||||||||||
|
|
@@ -27,56 +60,59 @@ export function createSnapshotHistory<T extends object>( | |||||||||||||||||||
| const snapshots: StoreSnapshot<T>[] = []; | ||||||||||||||||||||
| let cursor = -1; | ||||||||||||||||||||
| let nextId = 1; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| const apply = (snapshot: StoreSnapshot<T>): StoreSnapshot<T> => { | ||||||||||||||||||||
| const before = cloneState(store.getState()); | ||||||||||||||||||||
| try { | ||||||||||||||||||||
| store.setState(cloneState(snapshot.state) as Partial<T>); | ||||||||||||||||||||
| } catch (error) { | ||||||||||||||||||||
| store.setState(before as Partial<T>); | ||||||||||||||||||||
| throw error; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| return { ...snapshot, state: cloneState(snapshot.state) }; | ||||||||||||||||||||
| }; | ||||||||||||||||||||
| return { | ||||||||||||||||||||
| capture(label) { | ||||||||||||||||||||
| snapshots.splice(cursor + 1); | ||||||||||||||||||||
| const snapshot = { id: nextId++, label, state: cloneState(store.getState()) }; | ||||||||||||||||||||
| snapshots.push(snapshot); | ||||||||||||||||||||
| while (snapshots.length > limit) { | ||||||||||||||||||||
| snapshots.shift(); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Comment on lines
80
to
82
There was a problem hiding this comment. 🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win Reject negative history limits. With Proposed fix const limit = options.limit ?? 50;
+if (!Number.isSafeInteger(limit) || limit < 0) {
+ throw new RangeError('Snapshot history limit must be a non-negative integer');
+}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
| cursor = snapshots.length - 1; | ||||||||||||||||||||
| return { ...snapshot, state: cloneState(snapshot.state) }; | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| restore(id) { | ||||||||||||||||||||
| const index = snapshots.findIndex(snapshot => snapshot.id === id); | ||||||||||||||||||||
| if (index === -1) throw new Error(`Unknown store snapshot: ${id}`); | ||||||||||||||||||||
| const result = apply(snapshots[index]); | ||||||||||||||||||||
| // Only advance the cursor once the state change actually succeeded — | ||||||||||||||||||||
| // otherwise a thrown setState leaves cursor out of sync with live state. | ||||||||||||||||||||
| cursor = index; | ||||||||||||||||||||
| return result; | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| undo() { | ||||||||||||||||||||
| if (cursor <= 0) return null; | ||||||||||||||||||||
| const targetIndex = cursor - 1; | ||||||||||||||||||||
| const result = apply(snapshots[targetIndex]); | ||||||||||||||||||||
| cursor = targetIndex; | ||||||||||||||||||||
| return result; | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| redo() { | ||||||||||||||||||||
| if (cursor >= snapshots.length - 1) return null; | ||||||||||||||||||||
| const targetIndex = cursor + 1; | ||||||||||||||||||||
| const result = apply(snapshots[targetIndex]); | ||||||||||||||||||||
| cursor = targetIndex; | ||||||||||||||||||||
| return result; | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| list() { | ||||||||||||||||||||
| return snapshots.map(snapshot => ({ ...snapshot, state: cloneState(snapshot.state) })); | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| clear() { | ||||||||||||||||||||
| snapshots.splice(0); | ||||||||||||||||||||
| cursor = -1; | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| }; | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Restore real timers via
afterEach, not inline at test end.vi.useRealTimers()is only called at the end of the test body (Line 64). If an assertion (Lines 58 or 62) throws first, fake timers leak into subsequent tests.As per coding guidelines: "Use
vi.useFakeTimers()for debounce or persist tests andvi.useRealTimers()inafterEachhooks; real timers should be off by default."🐛 Proposed fix
vi.setSystemTime(500); // window has elapsed store.setState({ n: 3 }); expect(store.getHistory().past.length).toBe(2); - - vi.useRealTimers(); });📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines