- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 514
 
[Feat] Adds support for multiple chapters. #3802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…leading chapter numbers in the uri of {chapterId}/images/{image}. It now accounts for that and is working in a locally run user interface for an epub that was broken. I didn't check in the unit test over the GetBookPage method since it requires a specific file. I'll provide that in the PR description, though.
    
          
 | 
    
| 
           @majora2007 tagging in case this is something that you'd want to incorporate :)  | 
    
| 
           User sent file: The Color of the End - Haruo Iwamune.epub for testing this issue  | 
    
| 
           @pilotMike I was trying to find the file you sent me. Can you resend it to me so I can try to understand what this is trying to fix?  | 
    
| 
           @majora2007 Here is a burn after reading bin link to the file. Let me know if I need to resend another https://paste.michaeldileo.org/?6bc3d13ab21fd428#-Dy61zGXfnk4ocHYCEe5vMYoDRk6vpkfmaPTfX3gbUWC3  | 
    
| 
           Thanks  | 
    
| 
           I looked at the epub and it's not valid. It is essentially an epub with multiple folders within, each folder being a self contained epub. That's not part of the standard and seems to just be hacked together. How did you come across this book? Are you creating it to keep multiple chapters into a series (you would probably be better off taking each folder and just zipping into a chapter.epub)  | 
    
| 
           Its been a while since I did it, but iirc, each chapter was available individually of the manga and the "book" you'd buy had a certain number of chapters. I downloaded each chapter of the book and imported it into Calibre to combine/merge into a single epub. This file was how calibre did the output. For what it's worth, other e-reader software is able to open this file, such as the e-reader on OSX (and calibre of course).  | 
    



Adds support for multiple chapters. The previous version ignored any leading chapter numbers in the uri of {chapterId}/images/{image}. It now accounts for that and is working in a locally run user interface for an epub that was broken. I didn't check in the unit test over the GetBookPage method since it requires a specific file.
I can provide a link to the specific epub that wasn't working - it's 50MB though.
References: #3800
Added
Changed
pagevariable is now getting passed down and included in the key uri logic.Fixed
Not included unit test
Previous Result:

Current Result:
Screen.Recording.2025-05-13.at.11.36.39.AM.mov