Fix NVD CVE 2.0 API: cveId -> cveIds query parameter - #1
Open
KarloffsGhost wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIST's NVD CVE 2.0 API deprecated the cveId query parameter in favor of cveIds (still accepting a single ID). skills/reverse-engineering/scripts/cve_diff.py builds its NVD lookup URL with the old, deprecated parameter name.
This is the exact same one-line fix already verified end-to-end against this repository's own test suite in an isolated, network-disabled container (baseline and post-patch both: 485 passed, 6 skipped).
Full evidence, embedded here so nothing depends on an external link:
4d62be716fff90fb3249e525e8c771cf621f20c8skills/reverse-engineering/scripts/cve_diff.py91299d5f114d98d50b4213574a5067c13939cbd64401986b6d559eaf893a7202f3d040773583b9045509f249b6f5752b2445b590396395d65216668504b60024Opened against my own fork first.