Skip to content

Moved loggers from mnist to framework. Added tests for loggers#71

Merged
artiomn merged 15 commits intoKasperskyLab:masterfrom
DavidIkov:fixed-commits
Jul 2, 2025
Merged

Moved loggers from mnist to framework. Added tests for loggers#71
artiomn merged 15 commits intoKasperskyLab:masterfrom
DavidIkov:fixed-commits

Conversation

@DavidIkov
Copy link
Copy Markdown
Collaborator

@DavidIkov DavidIkov commented Jun 20, 2025

#47

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 20, 2025

CLA assistant check
All committers have signed the CLA.

Comment thread examples/mnist-learn/inference.cpp Outdated
Comment thread examples/mnist-learn/inference.cpp Outdated
Comment thread examples/mnist-learn/time_string.cpp Outdated
Comment thread examples/mnist-learn/train.cpp Outdated
Comment thread examples/mnist-learn/train.cpp
Comment thread knp/base-framework/include/knp/framework/monitoring/model_monitoring.h Outdated
Comment thread knp/base-framework/include/knp/framework/monitoring/model_monitoring.h Outdated
Comment thread knp/base-framework/include/knp/framework/monitoring/model_monitoring.h Outdated
Comment thread knp/tests/framework/CMakeLists.txt Outdated
Comment thread knp/tests/framework/model_monitoring_test.cpp Outdated
@artiomn artiomn changed the title moved loggers from mnist to framework. added tests for loggers Moved loggers from mnist to framework. added tests for loggers Jun 20, 2025
@artiomn
Copy link
Copy Markdown
Contributor

artiomn commented Jun 20, 2025

@DavidIkov , также некорректный формат сообщений о коммитах.
Сообщение должно выглядеть, как описано на вики.
Т.е., должен быть добавлен номер задачи, в данном случае, - issue, конкретно этого (47): #47

Comment thread knp/base-framework/impl/model_monitoring.cpp
Comment thread examples/mnist-learn/CMakeLists.txt
Comment thread examples/mnist-learn/inference.cpp Outdated
Comment thread examples/mnist-learn/inference.cpp Outdated
Comment thread examples/mnist-learn/train.cpp Outdated
Comment thread knp/base-framework/impl/model_monitoring.cpp Outdated
Comment thread knp/base-framework/impl/model_monitoring.cpp Outdated
Comment thread knp/tests/framework/model_monitoring_test.cpp
Comment thread knp/tests/framework/model_monitoring_test.cpp
Comment thread examples/mnist-learn/inference.h
Copy link
Copy Markdown
Contributor

@artiomn artiomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде нормально, только убрать ругань cppcheck, и всё ok.

Comment thread knp/tests/framework/model_monitoring_test.cpp Outdated
@artiomn artiomn changed the title Moved loggers from mnist to framework. added tests for loggers Moved loggers from mnist to framework. Added tests for loggers Jul 2, 2025
@artiomn artiomn merged commit 77d857d into KasperskyLab:master Jul 2, 2025
5 of 9 checks passed
@DavidIkov DavidIkov deleted the fixed-commits branch July 3, 2025 14:55
artiomn added a commit that referenced this pull request Apr 30, 2026
artiomn added a commit that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants