Skip to content

Moved some files from MNIST example to framework, according to: #83#88

Merged
artiomn merged 48 commits intoKasperskyLab:masterfrom
DavidIkov:master
Aug 4, 2025
Merged

Moved some files from MNIST example to framework, according to: #83#88
artiomn merged 48 commits intoKasperskyLab:masterfrom
DavidIkov:master

Conversation

@DavidIkov
Copy link
Copy Markdown
Collaborator

@DavidIkov DavidIkov commented Jul 23, 2025

No description provided.

DavidIkov added 29 commits July 3, 2025 23:08
@DavidIkov
fixed file documentation: KasperskyLab#83
5971cb0
@DavidIkov
moved wta outside: KasperskyLab#83
cf12309
@DavidIkov
fix for issue: KasperskyLab#69
163cea6
@DavidIkov
Fix for issue: KasperskyLab#84
ccb62a8
@DavidIkov
Added borders as parameter for wta: KasperskyLab#83
f09d5c4
@DavidIkov
Moved dataset processing to framework: KasperskyLab#83
418dccb
@DavidIkov
Made so data processing use filestreams intead of paths, more usefull…
02d9f57 
… behaviour. Removed magic numbers from main: KasperskyLab#83
@DavidIkov
Added comments to image_classification.h: KasperskyLab#83
368681e
@DavidIkov
Added more comments to fix build: KasperskyLab#83
72437e8
@DavidIkov
Changes ifstreams to istreams in image_classification: KasperskyLab#83
3fdef1a
@DavidIkov
Moved evaluation to framework: KasperskyLab#83
02ef0bc
@DavidIkov
Fixed comments: KasperskyLab#83
91193bb
@DavidIkov
Changed file descriptions: KasperskyLab#83
667def6
@DavidIkov
Moved generators: KasperskyLab#83
9b1870f
@DavidIkov
Refactored comments: KasperskyLab#83
96e3c07
@DavidIkov
Fixed comments issue: KasperskyLab#83
3d0bdca
@DavidIkov
Fixed comments: KasperskyLab#83
0d3a505
@DavidIkov
Added data processing test and fixed bug with dataset split: Kaspersk…
4618a3b 
…yLab#83
@DavidIkov
Remade classification dataset in the name of scalability: KasperskyLa…
cd7875b 
…b#83
@DavidIkov
Fixed mnist learn example: KasperskyLab#83
366a1fd
@DavidIkov
Added inference evaluation test. Some refactoring: KasperskyLab#83
2f2a4b0
@DavidIkov
Added projections creators for new generators: KasperskyLab#83
66bc91c
@DavidIkov
Added tests for new generators and refactored old tests: KasperskyLab#83
9c11cdd
@DavidIkov
Fixed comment issue: KasperskyLab#83
d4cea4c
@DavidIkov
Added wta test: KasperskyLab#83
9962d61
@DavidIkov
Merge remote-tracking branch 'upstream/master'
36da668
@DavidIkov
Removed debug code: KasperskyLab#83
9947acc
@DavidIkov
Fix for build: KasperskyLab#83
06f6eea
@DavidIkov
Fix for build: KasperskyLab#83
a249828
@DavidIkov DavidIkov temporarily deployed to pr-review-required July 23, 2025 10:48 — with GitHub Actions Inactive
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 07:27 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 07:27 — with GitHub Actions Failure
@DavidIkov DavidIkov temporarily deployed to pr-review-required August 1, 2025 07:27 — with GitHub Actions Inactive
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 07:27 — with GitHub Actions Failure
artiomn
artiomn requested changes Aug 1, 2025
View reviewed changes
Comment thread examples/mnist-learn/train.h Outdated
Comment thread knp/base-framework/impl/data_processing/classification/image.cpp
Comment thread knp/base-framework/impl/data_processing/classification/image.cpp
Comment thread knp/base-framework/impl/data_processing/classification/image.cpp Outdated
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/dataset.h
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/dataset.h Outdated
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/dataset.h
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/image.h
Comment thread knp/base-framework/include/knp/framework/inference_evaluation/classification.h Outdated
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 09:48 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 09:48 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 09:48 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 09:48 — with GitHub Actions Failure
@DavidIkov DavidIkov requested a review from artiomn August 1, 2025 09:48
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 13:23 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 13:23 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 13:23 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 13:23 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 13:31 — with GitHub Actions Failure
@DavidIkov DavidIkov had a problem deploying to pr-review-required August 1, 2025 13:31 — with GitHub Actions Failure
artiomn
artiomn requested changes Aug 1, 2025
View reviewed changes
Comment thread knp/base-framework/impl/inference_evaluation/perfomance_metrics.cpp Outdated
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/dataset.h Outdated
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/dataset.h
Comment thread knp/tests/framework/inference_evaluation_test.cpp
artiomn
artiomn requested changes Aug 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@artiomn artiomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const везде добавить.

Comment thread knp/base-framework/impl/data_processing/classification/image.cpp Outdated
Comment thread knp/base-framework/impl/data_processing/classification/image.cpp Outdated
Comment thread knp/base-framework/impl/data_processing/classification/image.cpp Outdated
Comment thread knp/base-framework/impl/data_processing/classification/image.cpp Outdated
Comment thread knp/base-framework/impl/inference_evaluation/classification.cpp Outdated
Comment thread knp/base-framework/impl/inference_evaluation/classification.cpp Outdated
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/image.h
Comment thread knp/tests/framework/data_processing_test.cpp Outdated
Comment thread knp/tests/framework/data_processing_test.cpp Outdated
Comment thread knp/tests/framework/inference_evaluation_test.cpp
artiomn
artiomn requested changes Aug 4, 2025
View reviewed changes
Comment thread knp/base-framework/include/knp/framework/data_processing/classification/image.h
Comment thread knp/base-framework/impl/inference_evaluation/classification.cpp Outdated
Comment thread knp/base-framework/impl/inference_evaluation/classification.cpp Outdated
artiomn
artiomn previously approved these changes Aug 4, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artiomn artiomn artiomn approved these changes

@a-vartenkov a-vartenkov Awaiting requested review from a-vartenkov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DavidIkov @artiomn