fix: (re)read pipewire nodes if empty#2
Conversation
pw-dump was only executed on pw-mixer start. so pipewire nodes had be active pw-mixer start to be recognized. so 1. start pw-mixer 2. start google chrome resulted in the fader for google chrome not working this pr fixes this by re-reading the config if idX.isEmpty()
|
Not nice about this PR: It tries to re-read the config on each MIDI message, so if a MIDI fader is moved from 0 to 127 while the id being empty, config is re-read 127 times |
|
As a side note: Source comments say, such an update happens every 100 MIDI messages, but I couldn't find an implementation of this. Instead of trying to fix that, I implemented this PR which IMHO is a more efficient approach. |
|
I removed the automatic pw-dump at some release and added a keybind for CYCLE key to trigger manual pw-dump to avoid high latency on changing volumes. Ill look at this implementation when I got time |
|
To clarify: This is not about deliberate changes to the config, for that the manual reload via Variant 1:
Variant 2:
vs
Without my PR it's like this: With my PR it's like this: |
pw-dump was only executed on pw-mixer start. so pipewire nodes had be active pw-mixer start to be recognized.
so
resulted in the fader for google chrome not working
this pr fixes this by re-reading the config if idX.isEmpty()